fix: standardize assertions using fail

Author: matteo-gobbo

test/multipart-big-stream.test.js

@@ -81,6 +81,6 @@ test('should emit fileSize limitation error during streaming', async function (t
     res.resume()
     await once(res, 'end')
   } catch (error) {
-    t.assert.fail(error, 'request')
+    t.assert.ifError(error, 'request')
   }
 })

test/multipart-fileLimit.test.js

@@ -157,7 +157,7 @@ test('should NOT throw fileSize limitation error when consuming the stream', asy
       t.assert.notStrictEqual(buffer.length, fileInputLength)
       reply.send(new fastify.multipartErrors.FilesLimitError())
     } catch {
-      t.assert.ifError('it should not throw')
+      t.assert.fail('it should not throw')
     }
   })
 
@@ -283,7 +283,7 @@ test('should NOT throw fileSize limitation error when throwFileSizeLimit is glob
       t.assert.notStrictEqual(buffer.length, fileInputLength)
       reply.send(new fastify.multipartErrors.FilesLimitError())
     } catch {
-      t.assert.ifError('it should not throw')
+      t.assert.fail('it should not throw')
     }
   })
 

test/multipart-security.test.js

@@ -263,7 +263,7 @@ test('should use default for fileSize', async function (t) {
     try {
       await part.toBuffer()
       reply.send('not ok')
-      t.assert.ok('it should throw')
+      t.assert.fail('it should throw')
     } catch (error) {
       t.assert.ok(error)
       reply.send(error)
@@ -311,7 +311,7 @@ test('should use default for parts - 1000', function (t, done) {
     try {
       // eslint-disable-next-lint no-empty
       for await (const _ of req.parts()) { console.assert(_) }
-      t.assert.ok('should throw on 1001')
+      t.assert.fail('should throw on 1001')
       reply.code(200).send()
     } catch (error) {
       t.assert.ok(error instanceof fastify.multipartErrors.PartsLimitError)

test/multipart-update-options-type.test.js

@@ -22,7 +22,7 @@ test('Should throw RequestFileTooLargeError when throwFileSizeLimit: true for fi
     try {
       const file = await req.file({ limits: { fileSize: 1 }, throwFileSizeLimit: true })
       await file.toBuffer()
-      t.assert.ok('should throw')
+      t.assert.fail('should throw')
       reply.code(200).send()
     } catch (error) {
       t.assert.ok(error instanceof fastify.multipartErrors.RequestFileTooLargeError)
@@ -77,7 +77,7 @@ test('Should NOT throw RequestFileTooLargeError when throwFileSizeLimit: false f
       t.assert.ok('OK')
       reply.code(200).send()
     } catch {
-      t.assert.ok('Should not throw')
+      t.assert.fail('Should not throw')
       reply.code(500).send()
     }
   })
@@ -128,7 +128,7 @@ test('Should throw RequestFileTooLargeError when throwFileSizeLimit: true for fi
       for await (const file of files) {
         await file.toBuffer()
       }
-      t.assert.ok('Should throw')
+      t.assert.fail('Should throw')
       reply.code(200).send()
     } catch (error) {
       t.assert.ok(error instanceof fastify.multipartErrors.RequestFileTooLargeError)
@@ -185,7 +185,7 @@ test('Should NOT throw RequestFileTooLargeError when throwFileSizeLimit: false f
       t.assert.ok('OK')
       reply.code(200).send()
     } catch {
-      t.assert.ok('Should not throw')
+      t.assert.fail('Should not throw')
       reply.code(500).send()
     }
   })