Merge pull request #99 from fastly/joeshaw/dont-defer-rw-close

joeshaw · web-flow · commit a015caa95bb2 · 2024-01-04T15:55:40.000-05:00
diff --git a/fsthttp/handle.go b/fsthttp/handle.go
@@ -35,8 +35,8 @@ func Serve(h Handler) {
 		}
 	})
 
-	defer clientResponseWriter.Close()
 	h.ServeHTTP(ctx, clientResponseWriter, clientRequest)
+	clientResponseWriter.Close()
 }
 
 // ServeFunc is sugar for Serve(HandlerFunc(f)).

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ func Serve(h Handler) {`
`35`	`35`	`}`
`36`	`36`	`})`
`37`	`37`
`38`		`- defer clientResponseWriter.Close()`
`39`	`38`	`h.ServeHTTP(ctx, clientResponseWriter, clientRequest)`
	`39`	`+ clientResponseWriter.Close()`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`// ServeFunc is sugar for Serve(HandlerFunc(f)).`