Update pre-commit hooks

Author: matthiask

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 exclude: ".yarn/|yarn.lock|\\.min\\.(css|js)$"
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v6.0.0
     hooks:
       - id: check-added-large-files
       - id: check-builtin-literals
@@ -14,33 +14,27 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://github.com/adamchainz/django-upgrade
-    rev: 1.13.0
+    rev: 1.25.0
     hooks:
       - id: django-upgrade
         args: [--target-version, "3.2"]
-  - repo: https://github.com/MarcoGorelli/absolufy-imports
-    rev: v0.3.1
-    hooks:
-      - id: absolufy-imports
-  - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.0.272"
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: "v0.12.8"
     hooks:
       - id: ruff
-  - repo: https://github.com/psf/black
-    rev: 23.3.0
-    hooks:
-      - id: black
-  - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.0.0-alpha.9-for-vscode
-    hooks:
-      - id: prettier
-        args: [--list-different, --no-semi]
-        exclude: "^conf/|.*\\.html$"
+        args: [--unsafe-fixes]
+      - id: ruff-format
+  - repo: https://github.com/biomejs/pre-commit
+    rev: "v2.1.4"
+    hooks:
+      - id: biome-check
+        args: [--unsafe]
+        verbose: true
   - repo: https://github.com/tox-dev/pyproject-fmt
-    rev: 0.11.2
+    rev: v2.6.0
     hooks:
       - id: pyproject-fmt
   - repo: https://github.com/abravalheri/validate-pyproject
-    rev: v0.13
+    rev: v0.24.1
     hooks:
       - id: validate-pyproject

biome.json

@@ -0,0 +1,55 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.1.4/schema.json",
+  "assist": { "actions": { "source": { "organizeImports": "off" } } },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "a11y": {
+        "noSvgWithoutTitle": "off"
+      },
+      "correctness": {
+        "noUndeclaredVariables": "error",
+        "noUnusedImports": "error",
+        "noUnusedVariables": "error",
+        "useHookAtTopLevel": "error"
+      },
+      "security": {
+        "noDangerouslySetInnerHtml": "warn"
+      },
+      "style": {
+        "noParameterAssign": "off",
+        "useForOf": "warn",
+        "useArrayLiterals": "error"
+      },
+      "suspicious": {
+        "noArrayIndexKey": "warn",
+        "noAssignInExpressions": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "semicolons": "asNeeded"
+    },
+    "globals": ["django", "CKEDITOR"]
+  },
+  "css": {
+    "formatter": {
+      "enabled": true
+    },
+    "linter": {
+      "enabled": true
+    }
+  },
+  "json": {
+    "formatter": {
+      "enabled": false
+    }
+  }
+}

feincms3_downloads/previews.py

@@ -4,7 +4,7 @@
 
 def preview_as_jpeg(path):
     with tempfile.TemporaryDirectory() as directory:
-        preview = "%s/preview.jpg" % directory
+        preview = f"{directory}/preview.jpg"
         if path.lower().endswith(".pdf"):
             cmd = [
                 "pdftocairo",
@@ -24,7 +24,7 @@ def preview_as_jpeg(path):
                 "300x300>",
                 "-quality",
                 "90",
-                "%s[0]" % path,
+                f"{path}[0]",
                 preview,
             ]
 

pyproject.toml

@@ -8,9 +8,9 @@ requires = [
 name = "feincms3-downloads"
 description = "Downloads plugin for feincms3"
 readme = "README.rst"
-license = {text = "MIT"}
+license = { text = "MIT" }
 authors = [
-    { name = "Matthias Kestenholz", email = "[email protected]" },
+  { name = "Matthias Kestenholz", email = "[email protected]" },
 ]
 requires-python = ">=3.8"
 classifiers = [
@@ -27,6 +27,8 @@ classifiers = [
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",
+  "Programming Language :: Python :: 3.12",
+  "Programming Language :: Python :: 3.13",
   "Topic :: Internet :: WWW/HTTP :: Dynamic Content",
   "Topic :: Software Development",
   "Topic :: Software Development :: Libraries :: Application Frameworks",
@@ -35,80 +37,77 @@ dynamic = [
   "version",
 ]
 dependencies = [
-  "Django>=3.2",
+  "django>=3.2",
   "feincms3>=4",
-  "Pillow",
+  "pillow",
 ]
-[project.optional-dependencies]
-tests = [
+optional-dependencies.tests = [
   "coverage",
 ]
-[project.urls]
-Homepage = "https://github.com/matthiask/feincms3-downloads/"
+urls.Homepage = "https://github.com/matthiask/feincms3-downloads/"
 
 [tool.hatch.version]
 path = "feincms3_downloads/__init__.py"
 
 [tool.ruff]
-extend-select = [
-  # pyflakes, pycodestyle
-  "F", "E", "W",
-  # mmcabe
-  "C90",
-  # isort
-  "I",
-  # pep8-naming
-  "N",
-  # pyupgrade
-  "UP",
-  # flake8-2020
-  "YTT",
-  # flake8-boolean-trap
-  "FBT",
-  # flake8-bugbear
-  "B",
+target-version = "py38"
+
+fix = true
+show-fixes = true
+lint.extend-select = [
   # flake8-builtins
   "A",
+  # flake8-bugbear
+  "B",
   # flake8-comprehensions
   "C4",
+  # mmcabe
+  "C90",
   # flake8-django
   "DJ",
+  "E",
+  # pyflakes, pycodestyle
+  "F",
+  # flake8-boolean-trap
+  "FBT",
   # flake8-logging-format
   "G",
-  # flake8-pie
-  "PIE",
-  # flake8-simplify
-  "SIM",
+  # isort
+  "I",
   # flake8-gettext
   "INT",
+  # pep8-naming
+  "N",
   # pygrep-hooks
   "PGH",
+  # flake8-pie
+  "PIE",
+  "PLC",
   # pylint
-  "PL",
+  "PLE",
+  "PLW",
   # unused noqa
   "RUF100",
+  # flake8-simplify
+  "SIM",
+  # pyupgrade
+  "UP",
+  "W",
+  # flake8-2020
+  "YTT",
 ]
-extend-ignore = [
+lint.extend-ignore = [
   # Allow zip() without strict=
   "B905",
   # No line length errors
   "E501",
 ]
-fix = true
-show-fixes = true
-target-version = "py38"
-
-[tool.ruff.isort]
-combine-as-imports = true
-lines-after-imports = 2
-
-[tool.ruff.mccabe]
-max-complexity = 15
-
-[tool.ruff.per-file-ignores]
-"*/migrat*/*" = [
+lint.per-file-ignores."*/migrat*/*" = [
   # Allow using PascalCase model names in migrations
   "N806",
   # Ignore the fact that migration files are invalid module names
   "N999",
 ]
+lint.isort.combine-as-imports = true
+lint.isort.lines-after-imports = 2
+lint.mccabe.max-complexity = 15

tests/testapp/models.py

@@ -9,6 +9,9 @@
 class Article(models.Model):
     regions = [Region(key="main", title=_("main"))]
 
+    def __str__(self):
+        return ""
+
 
 ArticlePlugin = create_plugin_base(Article)
 

tests/testapp/test_downloads.py

@@ -13,10 +13,10 @@
 
 def zero_management_form_data(prefix):
     return {
-        "%s-TOTAL_FORMS" % prefix: 0,
-        "%s-INITIAL_FORMS" % prefix: 0,
-        "%s-MIN_NUM_FORMS" % prefix: 0,
-        "%s-MAX_NUM_FORMS" % prefix: 1000,
+        f"{prefix}-TOTAL_FORMS": 0,
+        f"{prefix}-INITIAL_FORMS": 0,
+        f"{prefix}-MIN_NUM_FORMS": 0,
+        f"{prefix}-MAX_NUM_FORMS": 1000,
     }