Skip to content

Commit 18c03ef

Browse files
committed
fix: bump PHP version requirement to 7.1
PHP 7.0 reached end of life: https://www.php.net/supported-versions.php Fixes #447
1 parent 7281961 commit 18c03ef

File tree

4 files changed

+29
-28
lines changed

4 files changed

+29
-28
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
language: php
22

33
php:
4-
- '7.0'
4+
- '7.1'
55

66
cache:
77
directories:
@@ -23,7 +23,7 @@ jobs:
2323
include:
2424
- stage: test
2525
- stage: release
26-
php: '7.0'
26+
php: '7.1'
2727
install:
2828
- npm install
2929
- composer install --prefer-dist --no-interaction --optimize-autoloader

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"prefer-stable": true,
44
"config": {
55
"platform": {
6-
"php": "7.0.25"
6+
"php": "7.1.0"
77
}
88
},
99
"require": {

composer.lock

Lines changed: 23 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/extension.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import * as semver from 'semver'
66
import * as url from 'url'
77
import * as vscode from 'vscode'
88
import { LanguageClient, LanguageClientOptions, StreamInfo } from 'vscode-languageclient'
9+
const composerJson = require('../composer.json')
910

1011
export async function activate(context: vscode.ExtensionContext): Promise<void> {
1112
const conf = vscode.workspace.getConfiguration('php')
@@ -58,8 +59,8 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
5859
if (!/^\d+.\d+.\d+$/.test(version)) {
5960
version = version.replace(/(\d+.\d+.\d+)/, '$1-')
6061
}
61-
if (semver.lt(version, '7.0.0')) {
62-
vscode.window.showErrorMessage('The language server needs at least PHP 7 installed. Version found: ' + version)
62+
if (semver.lt(version, composerJson.config.platform.php)) {
63+
vscode.window.showErrorMessage('The language server needs at least PHP 7.1 installed. Version found: ' + version)
6364
return
6465
}
6566

0 commit comments

Comments
 (0)