Skip to content

Commit 0ab9e32

Browse files
coltondotiocoltondotio
committed
Revert "wip"
This reverts commit c5713a2.
1 parent c5713a2 commit 0ab9e32

File tree

8 files changed

+11
-28
lines changed

8 files changed

+11
-28
lines changed

‎packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/@sidebar/PageSidebar.tsx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ export default function PageSidebar({
9191
productSlug={found.currentProduct?.slug}
9292
versionId={found.currentVersion?.versionId}
9393
versionSlug={found.currentVersion?.slug}
94-
variantId={found.currentVariant?.variantId}
9594
versionIsDefault={found.isCurrentVersionDefault}
9695
productIsDefault={found.isCurrentProductDefault}
9796
/>
@@ -113,7 +112,6 @@ export default function PageSidebar({
113112
loaderData={prefetchedLoaderData}
114113
renderOptions={{
115114
forceClientRender: true,
116-
currentVariantId: found.currentVariant?.variantId,
117115
wrapPageNode: (node, component) => (
118116
<DeletablePageNodeWrapper
119117
node={node}

‎packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/PageNode.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ export default function PageNode(props: PageNode.Props) {
9191
productSlug={found.currentProduct?.slug}
9292
versionId={found.currentVersion?.versionId}
9393
versionSlug={found.currentVersion?.slug}
94-
variantId={found.currentVariant?.variantId}
9594
versionIsDefault={found.isCurrentVersionDefault}
9695
productIsDefault={found.isCurrentProductDefault}
9796
/>

‎packages/fern-docs/components/src/navigation/__tests__/NavigationStorage.test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ describe("NavigationStorage", () => {
101101
currentVersion: undefined,
102102
currentProduct: undefined,
103103
isCurrentVersionDefault: true,
104-
isCurrentProductDefault: true,
105-
currentVariant: undefined
104+
isCurrentProductDefault: true
106105
}
107106
},
108107
status: "changed" as const,

‎packages/fern-docs/components/src/navigation/__tests__/NavigationStore.canDirectlyEditDocsYmlNavigation.test.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ products:
113113
currentVersion: undefined,
114114
currentProduct: undefined,
115115
isCurrentVersionDefault: true,
116-
isCurrentProductDefault: true,
117-
currentVariant: undefined
116+
isCurrentProductDefault: true
118117
},
119118
targetSectionPath: []
120119
})

‎packages/fern-docs/components/src/navigation/__tests__/NavigationStore.rootNode.test.ts‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ describe("NavigationStore - rootNode management", () => {
125125
currentVersion: undefined,
126126
currentProduct: undefined,
127127
isCurrentVersionDefault: true,
128-
isCurrentProductDefault: true,
129-
currentVariant: undefined
128+
isCurrentProductDefault: true
130129
},
131130
targetSectionPath: [
132131
{
@@ -185,8 +184,7 @@ describe("NavigationStore - rootNode management", () => {
185184
currentVersion: undefined,
186185
currentProduct: undefined,
187186
isCurrentVersionDefault: true,
188-
isCurrentProductDefault: true,
189-
currentVariant: undefined
187+
isCurrentProductDefault: true
190188
},
191189
targetSectionPath: [
192190
{
@@ -233,8 +231,7 @@ describe("NavigationStore - rootNode management", () => {
233231
currentVersion: undefined,
234232
currentProduct: undefined,
235233
isCurrentVersionDefault: true,
236-
isCurrentProductDefault: true,
237-
currentVariant: undefined
234+
isCurrentProductDefault: true
238235
},
239236
targetSectionPath: [
240237
{
@@ -263,8 +260,7 @@ describe("NavigationStore - rootNode management", () => {
263260
currentVersion: undefined,
264261
currentProduct: undefined,
265262
isCurrentVersionDefault: true,
266-
isCurrentProductDefault: true,
267-
currentVariant: undefined
263+
isCurrentProductDefault: true
268264
},
269265
targetSectionPath: [
270266
{

‎packages/fern-docs/components/src/navigation/__tests__/NavigationStore.test.ts‎

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ describe("NavigationStore", () => {
5151
currentVersion: undefined,
5252
currentProduct: undefined,
5353
isCurrentVersionDefault: true,
54-
isCurrentProductDefault: true,
55-
currentVariant: undefined
54+
isCurrentProductDefault: true
5655
}
5756
});
5857

@@ -87,8 +86,7 @@ describe("NavigationStore", () => {
8786
currentVersion: undefined,
8887
currentProduct: undefined,
8988
isCurrentVersionDefault: true,
90-
isCurrentProductDefault: true,
91-
currentVariant: undefined
89+
isCurrentProductDefault: true
9290
}
9391
});
9492

@@ -128,8 +126,7 @@ describe("NavigationStore", () => {
128126
currentVersion: undefined,
129127
currentProduct: undefined,
130128
isCurrentVersionDefault: true,
131-
isCurrentProductDefault: true,
132-
currentVariant: undefined
129+
isCurrentProductDefault: true
133130
},
134131
targetSectionPath: []
135132
});
@@ -209,8 +206,7 @@ describe("NavigationStore", () => {
209206
currentVersion: undefined,
210207
currentProduct: undefined,
211208
isCurrentVersionDefault: true,
212-
isCurrentProductDefault: true,
213-
currentVariant: undefined
209+
isCurrentProductDefault: true
214210
}
215211
});
216212

@@ -241,8 +237,7 @@ describe("NavigationStore", () => {
241237
currentVersion: undefined,
242238
currentProduct: undefined,
243239
isCurrentVersionDefault: true,
244-
isCurrentProductDefault: true,
245-
currentVariant: undefined
240+
isCurrentProductDefault: true
246241
}
247242
});
248243

‎packages/fern-docs/components/src/navigation/migrations.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ function migrateV0ToV1(branchName: string, oldData: NavigationSnapshotV0): Navig
9292
: undefined,
9393
currentVersion: clientPageData?.navigationContext?.currentVersion,
9494
currentProduct: clientPageData?.navigationContext?.currentProduct,
95-
currentVariant: undefined, // NavigationSnapshotV0 did not have variants
9695
isCurrentVersionDefault: clientPageData?.navigationContext?.isCurrentVersionDefault ?? false,
9796
isCurrentProductDefault: clientPageData?.navigationContext?.isCurrentProductDefault ?? false
9897
};

‎packages/fern-docs/components/src/navigation/types.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export type SerializableFoundNode = Pick<
2121
| "currentTab"
2222
| "currentVersion"
2323
| "currentProduct"
24-
| "currentVariant"
2524
| "isCurrentVersionDefault"
2625
| "isCurrentProductDefault"
2726
>;
@@ -36,7 +35,6 @@ export function getSerializableFoundNode(foundNode: FernNavigation.utils.Node.Fo
3635
currentTab: foundNode.currentTab,
3736
currentVersion: foundNode.currentVersion,
3837
currentProduct: foundNode.currentProduct,
39-
currentVariant: foundNode.currentVariant,
4038
isCurrentVersionDefault: foundNode.isCurrentVersionDefault,
4139
isCurrentProductDefault: foundNode.isCurrentProductDefault
4240
};

0 commit comments

Comments
 (0)