chore: fix linter errors

Author: galargh

.golangci.yml

@@ -24,6 +24,7 @@ issues:
     # gosec
     - "^G101: Potential hardcoded credentials"
     - "^G108: Profiling endpoint is automatically exposed on /debug/pprof"
+    - "^G115: integer overflow conversion u?int(8|32|64)? -> u?int(8|32|64)?"
     - "^G204: Subprocess launched with (variable|a potential tainted input or cmd arguments)"
     - "^G301: Expect directory permissions to be 0750 or less"
     - "^G302: Expect file permissions to be 0600 or less"
@@ -47,6 +48,7 @@ issues:
     - "^var-naming: (method|range var) \\w*(Api|Http|Id|Rpc|Url)[^\\s]* should be \\w*(API|HTTP|ID|RPC|URL)"
     - "^var-naming: don't use underscores in Go names"
     - "^var-naming: don't use ALL_CAPS in Go names; use CamelCase"
+    - "^redefines-builtin-id: redefinition of the built-in (function|type) (max|min|cap|recover|new|error)"
 
   exclude-use-default: false
   exclude-rules:

api/api_test.go

@@ -16,12 +16,21 @@ import (
 	"github.com/filecoin-project/go-jsonrpc"
 )
 
+func goRoot() (string, error) {
+	out, err := exec.Command("go", "env", "GOROOT").Output()
+	if err != nil {
+		return "", err
+	}
+	return strings.TrimSpace(string(out)), nil
+}
+
 func goCmd() string {
 	var exeSuffix string
 	if runtime.GOOS == "windows" {
 		exeSuffix = ".exe"
 	}
-	path := filepath.Join(runtime.GOROOT(), "bin", "go"+exeSuffix)
+	root, _ := goRoot()
+	path := filepath.Join(root, "bin", "go"+exeSuffix)
 	if _, err := os.Stat(path); err == nil {
 		return path
 	}

chain/types/ethtypes/rlp.go

@@ -60,17 +60,16 @@ func encodeRLP(val interface{}) ([]byte, error) {
 		} else if len(data) <= 55 {
 			prefix := byte(0x80 + len(data))
 			return append([]byte{prefix}, data...), nil
-		} else {
-			lenInBytes, err := encodeLength(len(data))
-			if err != nil {
-				return nil, err
-			}
-			prefix := byte(0xb7 + len(lenInBytes))
-			return append(
-				[]byte{prefix},
-				append(lenInBytes, data...)...,
-			), nil
 		}
+		lenInBytes, err := encodeLength(len(data))
+		if err != nil {
+			return nil, err
+		}
+		prefix := byte(0xb7 + len(lenInBytes))
+		return append(
+			[]byte{prefix},
+			append(lenInBytes, data...)...,
+		), nil
 	case []interface{}:
 		encodedList, err := encodeRLPListItems(data)
 		if err != nil {

node/config/dep_test.go

@@ -9,12 +9,21 @@ import (
 	"testing"
 )
 
+func goRoot() (string, error) {
+	out, err := exec.Command("go", "env", "GOROOT").Output()
+	if err != nil {
+		return "", err
+	}
+	return strings.TrimSpace(string(out)), nil
+}
+
 func goCmd() string {
 	var exeSuffix string
 	if runtime.GOOS == "windows" {
 		exeSuffix = ".exe"
 	}
-	path := filepath.Join(runtime.GOROOT(), "bin", "go"+exeSuffix)
+	root, _ := goRoot()
+	path := filepath.Join(root, "bin", "go"+exeSuffix)
 	if _, err := os.Stat(path); err == nil {
 		return path
 	}