Enforce clean startup when importing from snapshot #10872
fridrik01
started this conversation in
Show and tell
Replies: 0 comments
This discussion is being transferred. The timeline may not be complete until it finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When starting Lotus from snapshot its easy to forget to manually cleanup the
.lotus/datastorefolder before running the--import-snapshotcommand. This may result in issues/errors that are difficult to debug.Proposal
We should check whether the
.lotus/datastorefolder exists when starting lotus--import-snapshot. If the folder exists, we should do one of:.lotus/datastoreand run the import again..lotus/datastoreand continue the import..lotus/datastorefolder and then (if Y) continue the import, or (if N) exit Lotus with non-zero exit code. Also introduce a--force-import-cleanupflag that if set will automatically select Y so this could be run non-interactively from a script.Discussion
a) Which (1,2,3) is the best
b) Its my understanding that
.lotus/datastoreis the only folder that needs to be deleted. However if we will be doing a cleanup of the.lotus/datastoreshould we also delete other folders like.lotus/sqlitealthough its not required .c) For context, this enhancement request started from this slack thread.
Beta Was this translation helpful? Give feedback.
All reactions