fix: make sure logs are strings not buffers

Author: petebacondarwin

examples/worker/src/index.ts

@@ -1,5 +1,6 @@
 export default {
 	async fetch() {
+		throw new Error('xxx');
 		return new Response('Hello World!');
 	},
 };

packages/vite-plugin-cloudflare/src/miniflare-options.ts

@@ -159,8 +159,11 @@ export function getMiniflareOptions(
 	return {
 		log: logger,
 		handleRuntimeStdio(stdout, stderr) {
-			stdout.forEach((data) => logger.info(data));
-			stderr.forEach((error) => logger.error(error));
+			const decoder = new TextDecoder();
+			stdout.forEach((data) => logger.info(decoder.decode(data)));
+			stderr.forEach((error) =>
+				logger.logWithLevel(LogLevel.ERROR, decoder.decode(error)),
+			);
 		},
 		...getPersistence(normalizedPluginConfig.persistPath),
 		workers: workers.map((workerOptions) => {
@@ -273,6 +276,9 @@ class ViteMiniflareLogger extends Log {
 	}
 
 	override logWithLevel(level: LogLevel, message: string) {
+		if (/^Ready on http/.test(message)) {
+			level = LogLevel.DEBUG;
+		}
 		switch (level) {
 			case LogLevel.ERROR:
 				return this.logger.error(message);

pnpm-lock.yaml

@@ -0,0 +1,54 @@
+import * as path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { cloudflare } from '@flarelabs-net/vite-plugin-cloudflare';
+import * as vite from 'vite';
+import { beforeEach, describe, expect, test } from 'vitest';
+import { getWorker, MockLogger, UNKNOWN_HOST } from '../test-helpers/src/utils';
+import type { FetchableDevEnvironment } from '../test-helpers/src/utils';
+
+const root = fileURLToPath(new URL('.', import.meta.url));
+let server: vite.ViteDevServer;
+let customLogger: MockLogger;
+let worker: FetchableDevEnvironment;
+
+describe('service bindings', async () => {
+	beforeEach(async ({ onTestFinished }) => {
+		customLogger = new MockLogger();
+		server = await vite.createServer({
+			customLogger,
+			plugins: [
+				cloudflare({
+					workers: {
+						worker: {
+							main: path.join(root, 'worker/index.ts'),
+							wranglerConfig: path.join(root, 'worker/wrangler.toml'),
+						},
+					},
+					persistTo: false,
+				}),
+			],
+		});
+		worker = getWorker(server);
+		onTestFinished(() => server.close());
+	});
+
+	test('returns a response from the worker', async () => {
+		const response = await worker.dispatchFetch(new Request(UNKNOWN_HOST));
+		const result = await response.json();
+
+		expect(result).toEqual({ status: 'OK' });
+	});
+
+	test('forwards console logs from the worker', async () => {
+		await worker.dispatchFetch(new Request(UNKNOWN_HOST));
+		expect(customLogger.getLogs('info')).toMatchInlineSnapshot(`
+			"console log
+			"
+		`);
+		expect(customLogger.getLogs('error')).toMatchInlineSnapshot(`
+			"console warn
+			console error
+			"
+		`);
+	});
+});

tests/integration/basic-functionality/basic-functionality.test.ts

@@ -0,0 +1,18 @@
+{
+	"name": "@tests/integration-basic-functionality",
+	"private": true,
+	"type": "module",
+	"scripts": {
+		"check:types": "tsc --build",
+		"test": "vitest run"
+	},
+	"devDependencies": {
+		"@cloudflare/workers-types": "catalog:default",
+		"@flarelabs-net/vite-plugin-cloudflare": "workspace:*",
+		"@vite-plugin-cloudflare/typescript-config": "workspace:*",
+		"typescript": "catalog:default",
+		"vite": "catalog:default",
+		"vitest": "catalog:default",
+		"wrangler": "catalog:default"
+	}
+}

tests/integration/basic-functionality/package.json

@@ -0,0 +1,5 @@
+{
+	"extends": "@vite-plugin-cloudflare/typescript-config/worker.json",
+	"include": ["**/*.ts"],
+	"exclude": ["*.test.ts"]
+}

tests/integration/basic-functionality/tsconfig.fixtures.json

@@ -0,0 +1,4 @@
+{
+	"extends": "@vite-plugin-cloudflare/typescript-config/base.json",
+	"include": ["*.test.ts"]
+}

tests/integration/basic-functionality/tsconfig.integration.json

@@ -0,0 +1,7 @@
+{
+	"files": [],
+	"references": [
+		{ "path": "./tsconfig.integration.json" },
+		{ "path": "./tsconfig.fixtures.json" }
+	]
+}

tests/integration/basic-functionality/tsconfig.json

@@ -0,0 +1,8 @@
+export default {
+	async fetch(request) {
+		console.log('console log');
+		console.warn('console warn');
+		console.error('console error');
+		return Response.json({ status: 'OK' });
+	},
+} satisfies ExportedHandler;

tests/integration/basic-functionality/worker/index.ts

@@ -0,0 +1 @@
+compatibility_date = "2024-09-09"