Closing temporary file to avoid double open bug

Author: momchil-flex

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+## [1.6.1] - 2022-8-31
+
+### Fixed
+- Bug in new simulation upload on Windows machines.
+
 ## [1.6.0] - 2022-8-29
 
 ### Added
@@ -389,7 +394,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Job and Batch classes for better simulation handling (eventually to fully replace webapi functions).
 - A large number of small improvements and bug fixes.
 
-[Unreleased]: https://github.com/flexcompute/tidy3d/compare/v1.6.0...develop
+[Unreleased]: https://github.com/flexcompute/tidy3d/compare/v1.6.1...develop
+[1.6.0]: https://github.com/flexcompute/tidy3d/compare/v1.6.0...v1.6.1
 [1.6.0]: https://github.com/flexcompute/tidy3d/compare/v1.5.0...v1.6.0
 [1.5.0]: https://github.com/flexcompute/tidy3d/compare/v1.4.1...v1.5.0
 [1.4.1]: https://github.com/flexcompute/tidy3d/compare/v1.4.0...v1.4.1

tidy3d/version.py

@@ -1,3 +1,3 @@
 """Defines the front end version of tidy3d"""
 
-__version__ = "1.6.0"
+__version__ = "1.6.1"

tidy3d/web/webapi.py

@@ -119,14 +119,17 @@ def upload(  # pylint:disable=too-many-locals,too-many-arguments
     # upload the file to s3
     log.debug("Uploading the json file")
 
-    with tempfile.NamedTemporaryFile() as data_file:
-        # pylint:disable=protected-access
-        json_string = simulation._json_string(data_file=data_file.name)
-        if data_file.name in json_string:
-            # Upload the extra data file if needed
-            json_string.replace(data_file.name, DATA_FILE_NAME)
-            upload_file(task_id, data_file.name, DATA_FILE_NAME)
-        upload_string(task_id, json_string, SIM_FILE_NAME)
+    # pylint:disable=consider-using-with
+    data_file = tempfile.NamedTemporaryFile()
+    # data_file will be reopened and closed in _json_string
+    data_file.close()
+    # pylint:disable=protected-access
+    json_string = simulation._json_string(data_file=data_file.name)
+    if data_file.name in json_string:
+        # Upload the extra data file if needed
+        json_string.replace(data_file.name, DATA_FILE_NAME)
+        upload_file(task_id, data_file.name, DATA_FILE_NAME)
+    upload_string(task_id, json_string, SIM_FILE_NAME)
 
     # log the url for the task in the web UI
     log.debug(f"{DEFAULT_CONFIG.website_endpoint}/folders/{folder.projectId}/tasks/{task_id}")