Skip to content

fix(security): Memory limits should be enforced in test/gha-e2e/juicefs/redis.yaml. #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
Merged

fix(security): Memory limits should be enforced in test/gha-e2e/juicefs/redis.yaml. #5359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/gha-e2e/juicefs/redis.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ spec:
- name: redis
# Pulls the default Redis image from Docker Hub
image: redis
resources:
limits:
memory: 512Mi
Comment on lines +35 to +37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding a memory limit is a great step towards improving resource management, it's also a best practice to define CPU limits, as well as requests for both CPU and memory. Setting requests helps Kubernetes with scheduling decisions, and setting CPU limits prevents the container from monopolizing CPU resources on the node. This leads to more stable and predictable behavior of your test environment.

        resources:
          limits:
            cpu: 1
            memory: 512Mi
          requests:
            cpu: 500m
            memory: 512Mi

ports:
- containerPort: 6379
hostPort: 6379
Expand Down
Loading