Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a3d596a

Browse files
committed
review: add todo against newly opened issue
1 parent 5c7daf1 commit a3d596a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,8 +1291,9 @@ - (NSString*)textInRange:(UITextRange*)range {
12911291
@"Expected a FlutterTextRange for range (got %@).", [range class]);
12921292
NSRange textRange = ((FlutterTextRange*)range).range;
12931293
if (textRange.location == NSNotFound) {
1294-
/// Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
1295-
/// against NSNotFound.
1294+
// Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
1295+
// against NSNotFound.
1296+
// TODO(hellohuanlin): root cause https://github.com/flutter/flutter/issues/160100
12961297
return nil;
12971298
}
12981299
// Sanitize the range to prevent going out of bounds.

shell/platform/darwin/ios/framework/Source/TextInputSemanticsObject.mm

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,9 @@ - (NSString*)textInRange:(UITextRange*)range {
4343
@"Expected a FlutterTextRange for range (got %@).", [range class]);
4444
NSRange textRange = ((FlutterTextRange*)range).range;
4545
if (textRange.location == NSNotFound) {
46-
/// Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
47-
/// against NSNotFound.
46+
// Avoids [crashes](https://github.com/flutter/flutter/issues/138464) from an assertion
47+
// against NSNotFound.
48+
// TODO(hellohuanlin): root cause https://github.com/flutter/flutter/issues/160100
4849
return nil;
4950
}
5051
return [self.text substringWithRange:textRange];

0 commit comments

Comments
 (0)