Skip to content

Commit aa83bde

Browse files
authored
[CQ] RestartFlutterDaemonAction: ignore spurious perf warning (#8506)
This inspection guards against eager presentation creation for actions that are referenced in `plugin.xml` but not used. This particular constructor is only used dynamically so there's nothing eager about it -- it will only be invoked on use. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
1 parent da07820 commit aa83bde

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/io/flutter/actions/RestartFlutterDaemonAction.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public static RestartFlutterDaemonAction forDeviceSelector() {
3636
/**
3737
* A constructor for dynamic invocation.
3838
*/
39+
@SuppressWarnings("ActionPresentationInstantiatedInCtor")
3940
private RestartFlutterDaemonAction(@Nullable @NlsActions.ActionText String text,
4041
@Nullable Icon icon) {
4142
super(text, text, icon);

0 commit comments

Comments
 (0)