Update image assets in travel app catalog for information card and itinerary items #479
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoreronmosele
changed the title
victoreronmosele
changed the title
victoreronmosele
changed the title
victoreronmosele
force-pushed
the
fix/travel-app-widget-catalog
branch
from
3def605 to
3fc3c79
Compare
The previous image url doesn't on web due because of CORS restrictions.
victoreronmosele
force-pushed
the
fix/travel-app-widget-catalog
branch
from
1e5010e to
86427a1
Compare
jacobsimionato
approved these changes
Nov 2, 2025
Collaborator
|
Thank you very much, Victor!! |
Contributor
Author
|
Happy to contribute! Just fixed the conflict. |
Collaborator
|
I'm afraid there are a couple of formatting fixes to do on this one before I can merge it! |
Contributor
Author
|
Will fix in a bit. |
victoreronmosele
force-pushed
the
fix/travel-app-widget-catalog
branch
from
54372f2 to
1afa017
Compare
Contributor
Author
|
Formatting issues are fixed now @jacobsimionato. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The travel app catalog throws errors for the following:
InformationCardandItineraryitems because theexampleDatastrings reference non-existent asset image paths,Imageitem when running on web due to CORS restrictions for theexampleDataimage URL.This PR updates:
exampleDatastrings to use existing one from theassets/travel_images/folder,exampleDatastring to use a non-restricted image URL (Flutter logo).Addresses #452
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.