Fix dangling references to AiClient. #490
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a large refactoring to rename AiClient to ContentGenerator and FirebaseAiClient to FirebaseAiContentGenerator. The changes are mostly correct and applied consistently across the codebase and documentation. However, I've found a few issues, including a critical error in an example in the main README.md that would prevent it from running, an inconsistency in the API of UiAgent shown in another README, and some minor issues in the documentation files. My review includes suggestions to fix these issues.
| if (type == MessageType.genUi) { | ||
| return GenUiSurface( | ||
| host: _genUiConversation.host, | ||
| host: _genUiConversation.genUiManager.host, |
There was a problem hiding this comment.
The property host does not exist on GenUiManager. The GenUiManager instance itself is the GenUiHost that should be passed to the GenUiSurface. You can either use _genUiConversation.host which is a getter for genUiManager, or access _genUiConversation.genUiManager directly.
| host: _genUiConversation.genUiManager.host, | |
| host: _genUiConversation.genUiManager, |
| ); | ||
| _uiAgent = UiAgent( | ||
| aiClient: _aiClient, | ||
| aiClient: _contentGenerator, |
There was a problem hiding this comment.
The UiAgent constructor is still using the aiClient parameter name, which is inconsistent with the rest of the refactoring where AiClient has been replaced by ContentGenerator and the parameter is named contentGenerator. For consistency across the API, consider renaming this parameter in the UiAgent class as well.
| aiClient: _contentGenerator, | |
| contentGenerator: _contentGenerator, |
gspencergoog
requested review from
jacobsimionato
and removed request for
jacobsimionato
2 participants
Description
Replace references to AiClient with the appropriate replacement.
Fixes #489