Skip to content

Commit 0571109

Browse files
Disable hot reload in web drive tests
1 parent caf8e0d commit 0571109

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

script/tool/lib/src/drive_examples_command.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,11 @@ class DriveExamplesCommand extends PackageLoopingCommand {
140140
platformWeb: <String>[
141141
'-d',
142142
'web-server',
143+
// TODO(stuartmorgan): Remove once drive works without it. See
144+
// https://github.com/dart-lang/sdk/issues/60289 and
145+
// https://github.com/flutter/flutter/pull/169174
146+
if (platform.environment['CHANNEL']?.toLowerCase() == 'master')
147+
'--no-web-experimental-hot-reload',
143148
'--web-port=7357',
144149
'--browser-name=chrome',
145150
if (useWasm) '--wasm',

script/tool/test/drive_examples_command_test.dart

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -840,6 +840,7 @@ void main() {
840840
'drive',
841841
'-d',
842842
'web-server',
843+
'--no-web-experimental-hot-reload',
843844
'--web-port=7357',
844845
'--browser-name=chrome',
845846
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -891,6 +892,7 @@ void main() {
891892
'drive',
892893
'-d',
893894
'web-server',
895+
'--no-web-experimental-hot-reload',
894896
'--web-port=7357',
895897
'--browser-name=chrome',
896898
'--wasm',
@@ -941,6 +943,7 @@ void main() {
941943
'drive',
942944
'-d',
943945
'web-server',
946+
'--no-web-experimental-hot-reload',
944947
'--web-port=7357',
945948
'--browser-name=chrome',
946949
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -993,6 +996,7 @@ void main() {
993996
'drive',
994997
'-d',
995998
'web-server',
999+
'--no-web-experimental-hot-reload',
9961000
'--web-port=7357',
9971001
'--browser-name=chrome',
9981002
'--chrome-binary=/path/to/chrome',
@@ -1444,6 +1448,7 @@ void main() {
14441448
'drive',
14451449
'-d',
14461450
'web-server',
1451+
'--no-web-experimental-hot-reload',
14471452
'--web-port=7357',
14481453
'--browser-name=chrome',
14491454
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -1459,6 +1464,7 @@ void main() {
14591464
'drive',
14601465
'-d',
14611466
'web-server',
1467+
'--no-web-experimental-hot-reload',
14621468
'--web-port=7357',
14631469
'--browser-name=chrome',
14641470
'--screenshot=/path/to/logs/plugin_example-drive',
@@ -1558,6 +1564,7 @@ void main() {
15581564
'drive',
15591565
'-d',
15601566
'web-server',
1567+
'--no-web-experimental-hot-reload',
15611568
'--web-port=7357',
15621569
'--browser-name=chrome',
15631570
'--screenshot=/path/to/logs/a_package_example-drive',
@@ -1603,6 +1610,7 @@ void main() {
16031610
'drive',
16041611
'-d',
16051612
'web-server',
1613+
'--no-web-experimental-hot-reload',
16061614
'--web-port=7357',
16071615
'--browser-name=chrome',
16081616
'--driver',
@@ -1682,6 +1690,7 @@ void main() {
16821690
'drive',
16831691
'-d',
16841692
'web-server',
1693+
'--no-web-experimental-hot-reload',
16851694
'--web-port=7357',
16861695
'--browser-name=chrome',
16871696
'--screenshot=/path/to/logs/a_package_example_with_web-drive',

0 commit comments

Comments
 (0)