Review feedback

Author: stuartmorgan-g

packages/google_sign_in/google_sign_in/lib/google_sign_in.dart

@@ -54,9 +54,11 @@ class GoogleSignInAccount implements GoogleIdentity {
   /// Returns authentication tokens for this account.
   ///
   /// This returns the authentication information that was returned at the time
-  /// of the initial authentication. Clients are strongly encouraged to use this
-  /// information immediately after authentication, as tokens are subject to
-  /// expiration, and obtaining new tokens requires re-authenticating.
+  /// of the initial authentication.
+  ///
+  /// Clients are strongly encouraged to use this information immediately after
+  /// authentication, as tokens are subject to expiration, and obtaining new
+  /// tokens requires re-authenticating.
   GoogleSignInAuthentication get authentication {
     return GoogleSignInAuthentication(idToken: _authenticationTokens.idToken);
   }

packages/google_sign_in/google_sign_in_android/lib/google_sign_in_android.dart

@@ -63,6 +63,9 @@ class GoogleSignInAndroid extends GoogleSignInPlatform {
         : _authenticationResultFromPlatformCredential(credential);
   }
 
+  @override
+  bool supportsAuthenticate() => true;
+
   @override
   Future<AuthenticationResults> authenticate(
       AuthenticateParameters params) async {
@@ -100,6 +103,9 @@ class GoogleSignInAndroid extends GoogleSignInPlatform {
     await signOut(const SignOutParams());
   }
 
+  @override
+  bool authorizationRequiresUserInteraction() => false;
+
   @override
   Future<ClientAuthorizationTokenData?> clientAuthorizationTokensForScopes(
       ClientAuthorizationTokensForScopesParameters params) async {

packages/google_sign_in/google_sign_in_android/test/google_sign_in_android_test.dart

@@ -50,6 +50,16 @@ void main() {
     expect(GoogleSignInPlatform.instance, isA<GoogleSignInAndroid>());
   });
 
+  group('support queries', () {
+    test('reports support for authenticate', () {
+      expect(googleSignIn.supportsAuthenticate(), true);
+    });
+
+    test('reports no requirement for user interaction to authorize', () {
+      expect(googleSignIn.authorizationRequiresUserInteraction(), false);
+    });
+  });
+
   group('attemptLightweightAuthentication', () {
     test('passes explicit server client ID', () async {
       const String serverClientId = 'aServerClient';

packages/google_sign_in/google_sign_in_ios/lib/google_sign_in_ios.dart

@@ -59,6 +59,9 @@ class GoogleSignInIOS extends GoogleSignInPlatform {
     return _authenticationResultsFromSignInSuccess(success);
   }
 
+  @override
+  bool supportsAuthenticate() => true;
+
   @override
   Future<AuthenticationResults> authenticate(
       AuthenticateParameters params) async {
@@ -99,6 +102,9 @@ class GoogleSignInIOS extends GoogleSignInPlatform {
     await signOut(const SignOutParams());
   }
 
+  @override
+  bool authorizationRequiresUserInteraction() => false;
+
   @override
   Future<ClientAuthorizationTokenData?> clientAuthorizationTokensForScopes(
       ClientAuthorizationTokensForScopesParameters params) async {

packages/google_sign_in/google_sign_in_ios/test/google_sign_in_ios_test.dart

@@ -35,6 +35,16 @@ void main() {
     expect(GoogleSignInPlatform.instance, isA<GoogleSignInIOS>());
   });
 
+  group('support queries', () {
+    test('reports support for authenticate', () {
+      expect(googleSignIn.supportsAuthenticate(), true);
+    });
+
+    test('reports no requirement for user interaction to authorize', () {
+      expect(googleSignIn.authorizationRequiresUserInteraction(), false);
+    });
+  });
+
   group('init', () {
     test('passes expected values', () async {
       const String clientId = 'aClient';

packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart

@@ -59,28 +59,27 @@ abstract class GoogleSignInPlatform extends PlatformInterface {
   Future<AuthenticationResults?>? attemptLightweightAuthentication(
       AttemptLightweightAuthenticationParameters params);
 
-  /// Signs in with explicit user intent.
-  ///
-  /// This is intended to support the use case where the user has expressed
-  /// an explicit intent to sign in.
-  Future<AuthenticationResults> authenticate(AuthenticateParameters params);
-
   /// Returns true if the platform implementation supports the [authenticate]
   /// method.
   ///
   /// The default is true, but platforms that cannot support [authenticate] can
   /// override this to return false, throw [UnsupportedError] from
   /// [authenticate], and provide a different, platform-specific authentication
   /// flow.
-  bool supportsAuthenticate() => true;
+  bool supportsAuthenticate();
+
+  /// Signs in with explicit user intent.
+  ///
+  /// This is intended to support the use case where the user has expressed
+  /// an explicit intent to sign in.
+  Future<AuthenticationResults> authenticate(AuthenticateParameters params);
 
   /// Whether or not authorization calls that could show UI must be called from
   /// a user interaction, such as a button press, on the current platform.
   ///
-  /// The default is true, but platforms that can fail to show UI without an
-  /// active user interaction should override this to return true. For instance,
-  /// this should return true for a web implementations that uses popups.
-  bool authorizationRequiresUserInteraction() => false;
+  /// Platforms that can fail to show UI without an active user interaction,
+  /// such as a web implementations that uses popups, should return false.
+  bool authorizationRequiresUserInteraction();
 
   /// Returns the tokens used to authenticate other API calls from a client.
   ///
@@ -99,8 +98,8 @@ abstract class GoogleSignInPlatform extends PlatformInterface {
   /// Signs out previously signed in accounts.
   Future<void> signOut(SignOutParams params);
 
-  /// Revokes all of the scopes that all signed in users granted, and then them
-  /// out.
+  /// Revokes all of the scopes that all signed in users granted, and then signs
+  /// them out.
   Future<void> disconnect(DisconnectParams params);
 
   /// Returns a stream of authentication events.
@@ -136,11 +135,21 @@ class _PlaceholderImplementation extends GoogleSignInPlatform {
     throw UnimplementedError();
   }
 
+  @override
+  bool supportsAuthenticate() {
+    throw UnimplementedError();
+  }
+
   @override
   Future<AuthenticationResults> authenticate(AuthenticateParameters params) {
     throw UnimplementedError();
   }
 
+  @override
+  bool authorizationRequiresUserInteraction() {
+    throw UnimplementedError();
+  }
+
   @override
   Future<ClientAuthorizationTokenData?> clientAuthorizationTokensForScopes(
       ClientAuthorizationTokensForScopesParameters params) {

packages/google_sign_in/google_sign_in_platform_interface/test/google_sign_in_platform_interface_test.dart

@@ -112,11 +112,17 @@ class ExtendsGoogleSignInPlatform extends GoogleSignInPlatform {
     return null;
   }
 
+  @override
+  bool supportsAuthenticate() => false;
+
   @override
   Future<AuthenticationResults> authenticate(AuthenticateParameters params) {
     throw UnimplementedError();
   }
 
+  @override
+  bool authorizationRequiresUserInteraction() => false;
+
   @override
   Future<ClientAuthorizationTokenData?> clientAuthorizationTokensForScopes(
       ClientAuthorizationTokensForScopesParameters params) async {

packages/google_sign_in/google_sign_in_web/example/integration_test/web_only_test.dart

@@ -101,4 +101,14 @@ class NonWebImplementation extends GoogleSignInPlatform {
   Future<void> signOut(SignOutParams params) {
     throw UnimplementedError();
   }
+
+  @override
+  bool authorizationRequiresUserInteraction() {
+    throw UnimplementedError();
+  }
+
+  @override
+  bool supportsAuthenticate() {
+    throw UnimplementedError();
+  }
 }