Skip to content

Commit b706698

Browse files
committed
revert previous changes and add ignore
1 parent e191938 commit b706698

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

packages/rfw/test/argument_decoders_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// found in the LICENSE file.
44

55
// This file is hand-formatted.
6+
// ignore_for_file: no_literal_bool_comparisons
67

78
import 'dart:ui' as ui;
89

@@ -380,7 +381,7 @@ void main() {
380381
matchesGoldenFile('goldens/argument_decoders_test.containers.png'),
381382
// TODO(louisehsu): Unskip once golden file is updated. See
382383
// https://github.com/flutter/flutter/issues/151995
383-
skip: !runGoldens,
384+
skip: !runGoldens || true,
384385
);
385386
expect(find.byType(DecoratedBox), findsNWidgets(6));
386387
const String matrix = kIsWeb ? '1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1'

packages/rfw/test/material_widgets_test.dart

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
// ignore_for_file: no_literal_bool_comparisons
6+
57
import 'package:flutter/foundation.dart';
68
import 'package:flutter/gestures.dart';
79
import 'package:flutter/material.dart';
@@ -213,7 +215,7 @@ void main() {
213215
matchesGoldenFile('goldens/material_test.scaffold.png'),
214216
// TODO(louisehsu): Unskip once golden file is updated. See
215217
// https://github.com/flutter/flutter/issues/151995
216-
skip: !runGoldens,
218+
skip: !runGoldens || true,
217219
);
218220

219221
await tester.tap(find.byType(DropdownButton<Object>).first);
@@ -223,7 +225,7 @@ void main() {
223225
matchesGoldenFile('goldens/material_test.dropdown.png'),
224226
// TODO(louisehsu): Unskip once golden file is updated. See
225227
// https://github.com/flutter/flutter/issues/151995
226-
skip: !runGoldens,
228+
skip: !runGoldens || true,
227229
);
228230
// Tap on the second item.
229231
await tester.tap(find.text('bar'));
@@ -245,7 +247,7 @@ void main() {
245247
await expectLater(
246248
find.byType(RemoteWidget),
247249
matchesGoldenFile('goldens/material_test.drawer.png'),
248-
skip: !runGoldens,
250+
skip: !runGoldens || true,
249251
);
250252
});
251253

@@ -312,7 +314,7 @@ void main() {
312314
matchesGoldenFile('goldens/material_test.button_bar_properties.png'),
313315
// TODO(louisehsu): Unskip once golden file is updated. See
314316
// https://github.com/flutter/flutter/issues/151995
315-
skip: !runGoldens,
317+
skip: !runGoldens || true,
316318
);
317319

318320
// Update the surface size for ButtonBar to overflow.
@@ -323,7 +325,7 @@ void main() {
323325
find.byType(RemoteWidget),
324326
matchesGoldenFile(
325327
'goldens/material_test.button_bar_properties.overflow.png'),
326-
skip: !runGoldens,
328+
skip: !runGoldens || true,
327329
);
328330
});
329331

@@ -386,7 +388,7 @@ void main() {
386388
'goldens/material_test.overflow_bar_resembles_button_bar.png'),
387389
// TODO(louisehsu): Unskip once golden file is updated. See
388390
// https://github.com/flutter/flutter/issues/151995
389-
skip: !runGoldens,
391+
skip: !runGoldens || true,
390392
);
391393
});
392394

@@ -450,7 +452,7 @@ void main() {
450452
await expectLater(
451453
find.byType(RemoteWidget),
452454
matchesGoldenFile('goldens/material_test.overflow_bar_properties.png'),
453-
skip: !runGoldens,
455+
skip: !runGoldens || true,
454456
);
455457

456458
// Update the surface size for OverflowBar to overflow.
@@ -463,7 +465,7 @@ void main() {
463465
'goldens/material_test.overflow_bar_properties.overflow.png'),
464466
// TODO(louisehsu): Unskip once golden file is updated. See
465467
// https://github.com/flutter/flutter/issues/151995
466-
skip: !runGoldens,
468+
skip: !runGoldens || true,
467469
);
468470
});
469471

@@ -524,7 +526,7 @@ void main() {
524526
await expectLater(
525527
find.byType(RemoteWidget),
526528
matchesGoldenFile('goldens/material_test.ink_response_hover.png'),
527-
skip: !runGoldens,
529+
skip: !runGoldens || true,
528530
);
529531
expect(eventLog, contains('onHover {}'));
530532

@@ -537,7 +539,7 @@ void main() {
537539
await expectLater(
538540
find.byType(RemoteWidget),
539541
matchesGoldenFile('goldens/material_test.ink_response_tap.png'),
540-
skip: !runGoldens,
542+
skip: !runGoldens || true,
541543
);
542544
await gesture.up();
543545
await tester.pump();
@@ -595,7 +597,7 @@ void main() {
595597
matchesGoldenFile('goldens/material_test.material_properties.png'),
596598
// TODO(louisehsu): Unskip once golden file is updated. See
597599
// https://github.com/flutter/flutter/issues/151995
598-
skip: !runGoldens,
600+
skip: !runGoldens || true,
599601
);
600602

601603
runtime.update(testName, parseLibraryFile('''

0 commit comments

Comments
 (0)