Add tests for tool change

Author: reidbaker

script/tool/test/gradle_check_command_test.dart

@@ -17,6 +17,8 @@ const String _defaultFakeNamespace = 'dev.flutter.foo';
 void main() {
   late CommandRunner<void> runner;
   late Directory packagesDir;
+  const String javaIncompatabilityIndicator =
+      'build.gradle(.kts) must set an explicit Java compatibility version.';
 
   setUp(() {
     final GitDir gitDir;
@@ -46,6 +48,9 @@ void main() {
     bool useDeprecatedCompileSdkVersion = false,
     bool usePropertyAssignment = true,
     String compileSdk = '36',
+    bool includeKotlinOptions = true,
+    bool commentKotlinOptions = false,
+    bool useDeprecatedJvmTarget = false,
   }) {
     final File buildGradle = package
         .platformDirectory(FlutterPlatform.android)
@@ -69,11 +74,17 @@ java {
 
 ''';
     final String sourceCompat =
-        '${commentSourceLanguage ? '// ' : ''}sourceCompatibility = JavaVersion.VERSION_11';
+        '${commentSourceLanguage ? '// ' : ''}sourceCompatibility = JavaVersion.VERSION_17';
     final String targetCompat =
-        '${commentSourceLanguage ? '// ' : ''}targetCompatibility = JavaVersion.VERSION_11';
+        '${commentSourceLanguage ? '// ' : ''}targetCompatibility = JavaVersion.VERSION_17';
     final String namespace =
         "    ${commentNamespace ? '// ' : ''}namespace = '$_defaultFakeNamespace'";
+    final String jvmTarget =
+        useDeprecatedJvmTarget ? '17' : 'JavaVersion.VERSION_17.toString()';
+    final String kotlinConfig = '''
+    ${commentKotlinOptions ? '//' : ''}kotlinOptions {
+        ${commentKotlinOptions ? '//' : ''}jvmTarget = $jvmTarget
+    ${commentKotlinOptions ? '//' : ''}}''';
 
     buildGradle.writeAsStringSync('''
 group 'dev.flutter.plugins.fake'
@@ -101,6 +112,7 @@ ${warningsConfigured ? warningConfig : ''}
         ${includeSourceCompat ? sourceCompat : ''}
         ${includeTargetCompat ? targetCompat : ''}
     }
+    ${includeKotlinOptions ? kotlinConfig : ''}
     testOptions {
         unitTests.includeAndroidResources = true
     }
@@ -351,8 +363,7 @@ dependencies {
     expect(
       output,
       containsAllInOrder(<Matcher>[
-        contains(
-            'build.gradle must set an explicit Java compatibility version.'),
+        contains(javaIncompatabilityIndicator),
       ]),
     );
   });
@@ -375,8 +386,7 @@ dependencies {
     expect(
       output,
       containsAllInOrder(<Matcher>[
-        contains(
-            'build.gradle must set an explicit Java compatibility version.'),
+        contains(javaIncompatabilityIndicator),
       ]),
     );
   });
@@ -457,8 +467,7 @@ dependencies {
     expect(
       output,
       containsAllInOrder(<Matcher>[
-        contains(
-            'build.gradle must set an explicit Java compatibility version.'),
+        contains(javaIncompatabilityIndicator),
       ]),
     );
   });
@@ -480,8 +489,7 @@ dependencies {
     expect(
       output,
       containsAllInOrder(<Matcher>[
-        contains(
-            'build.gradle must set an explicit Java compatibility version.'),
+        contains(javaIncompatabilityIndicator),
       ]),
     );
   });
@@ -1162,4 +1170,95 @@ dependencies {
       );
     });
   });
+
+  group('kotlinOptions check', () {
+    test('passes when kotlin options are specified', () async {
+      final RepositoryPackage package =
+          createFakePlugin('a_plugin', packagesDir, examples: <String>[]);
+      writeFakePluginBuildGradle(
+        package,
+        includeLanguageVersion: true,
+        // ignore: avoid_redundant_argument_values ensure codepath is tested if defaults change.
+        includeKotlinOptions: true,
+      );
+      writeFakeManifest(package);
+
+      final List<String> output =
+          await runCapturingPrint(runner, <String>['gradle-check']);
+
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains('Validating android/build.gradle'),
+        ]),
+      );
+    });
+
+    test('passes when kotlin options are not specified', () async {
+      final RepositoryPackage package =
+          createFakePlugin('a_plugin', packagesDir, examples: <String>[]);
+      writeFakePluginBuildGradle(
+        package,
+        includeLanguageVersion: true,
+        includeKotlinOptions: false,
+      );
+      writeFakeManifest(package);
+
+      final List<String> output =
+          await runCapturingPrint(runner, <String>['gradle-check']);
+
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains('Validating android/build.gradle'),
+        ]),
+      );
+    });
+
+    test('passes when kotlin options commented out', () async {
+      final RepositoryPackage package =
+          createFakePlugin('a_plugin', packagesDir, examples: <String>[]);
+      writeFakePluginBuildGradle(
+        package,
+        includeLanguageVersion: true,
+        commentKotlinOptions: true,
+      );
+      writeFakeManifest(package);
+
+      final List<String> output =
+          await runCapturingPrint(runner, <String>['gradle-check']);
+
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains('Validating android/build.gradle'),
+        ]),
+      );
+    });
+
+    test('fails when kotlin options uses string jvm version', () async {
+      final RepositoryPackage package =
+          createFakePlugin('a_plugin', packagesDir, examples: <String>[]);
+      writeFakePluginBuildGradle(
+        package,
+        includeLanguageVersion: true,
+        useDeprecatedJvmTarget: true,
+      );
+      writeFakeManifest(package);
+
+      Error? commandError;
+      final List<String> output = await runCapturingPrint(
+          runner, <String>['gradle-check'], errorHandler: (Error e) {
+        commandError = e;
+      });
+
+      expect(commandError, isA<ToolExit>());
+      expect(
+        output,
+        containsAllInOrder(<Matcher>[
+          contains('build.gradle(.kts) sets jvmTarget then it must use JavaVersion syntax'),
+        ]),
+      );
+    });
+  });
 }