Skip to content

Commit f1ebb5d

Browse files
committed
Merge #819: Update nixpkgs
e6e3a13 work around CVE-2024-23342 for pkgs `hwi`, `trezor` (Erik Arvstedt) c4cd252 update nixpkgs (Erik Arvstedt) Pull request description: ACKs for top commit: jonasnick: ACK e6e3a13 Tree-SHA512: f0f5bcbe0ea28f5870aed7bd983904fe3d57aedad45955835ace1fb151f48f169977f453d41a071b60e0e27af6fc92572c629627dfc8d81012c0bb4241a7f459
2 parents b217b60 + e6e3a13 commit f1ebb5d

File tree

6 files changed

+27
-9
lines changed

6 files changed

+27
-9
lines changed

flake.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/hardware-wallets.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ in {
6262
});
6363
})
6464
(mkIf cfg.trezor {
65-
environment.systemPackages = [ pkgs.python3.pkgs.trezor ];
65+
environment.systemPackages = [ config.nix-bitcoin.pkgs.pyPkgs.nbPython3PackagesWithUnlockedEcdsa.trezor ];
6666
# Don't use rules from nixpkgs because we want to use our own group.
6767
services.udev.packages = lib.singleton (pkgs.writeTextFile {
6868
name = "trezord-udev-rules";

pkgs/clnrest/default.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ rustPlatform.buildRustPackage rec {
1111

1212
inherit (clightning) src;
1313

14-
cargoHash = "sha256-UxMXBO/rpanNU8vz8y4V5wSbCNHKYmVXtoGRpOqI+A0=";
14+
cargoHash = "sha256-2xOLwj42Ua85+kn73y+5q3YmzKYMCjxLlq/UrYjiZv0=";
1515

1616
depsExtraArgs = {
1717
nativeBuildInputs = [ unzip ];

pkgs/default.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ let self = {
2626
trustedcoin = pkgs.callPackage ./trustedcoin { };
2727

2828
bitcoind_29 = pkgs.callPackage ./bitcoind_29 {};
29+
inherit (self.pyPkgs.nbPython3PackagesWithUnlockedEcdsa) hwi;
2930

3031
pyPkgs = import ./python-packages self pkgs.python3;
3132
inherit (self.pyPkgs)

pkgs/pinned.nix

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ pkgs: pkgsUnstable:
55
elementsd
66
extra-container
77
fulcrum
8-
hwi
98
lightning-pool
109
lndconnect;
1110

pkgs/python-packages/default.nix

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,22 @@ rec {
3333
}).pkgs;
3434

3535
nbPython3PackagesJoinmarket = nbPython3Packages;
36+
37+
# Re-enable pkgs `hwi`, `trezor` that are unaffected by `CVE-2024-23342` because
38+
# they don't use python pkg `ecdsa` for signing.
39+
# These packages no longer evaluate in nixpkgs after `ecdsa` was tagged with this CVE.
40+
nbPython3PackagesWithUnlockedEcdsa = let
41+
python3PackagesWithUnlockedEcdsa = (python3.override {
42+
packageOverrides = self: super: {
43+
ecdsa = super.ecdsa.overrideAttrs (old: {
44+
meta = old.meta // {
45+
knownVulnerabilities = builtins.filter (x: x != "CVE-2024-23342") old.meta.knownVulnerabilities;
46+
};
47+
});
48+
};
49+
}).pkgs;
50+
in {
51+
hwi = with python3PackagesWithUnlockedEcdsa; toPythonApplication hwi;
52+
inherit (python3PackagesWithUnlockedEcdsa) trezor;
53+
};
3654
}

0 commit comments

Comments
 (0)