v5.0.0 always returns Buffer object

[Yazaar]

Case description

Version 5.0.0 always return a Buffer object, compared to version 4.0.0 which returned a string if encoding option is set to 'base64'. This was introduced Sep 3, 2024 on commit :arrow-up: upgrade puppeteer to 23.2.2.

Was this transition expected by the v5.0.0 update?

Suggestion

Make node-html-to-image return a base64 string similar to v4.0.0.

Note: breaking change considering the returned data type changes from Buffer to string. Even if I did expect v5.0.0 to return a string to begin with after transitioning from v4.0.0 to v5.0.0.

node-html-to-image/src/screenshot.ts

Lines 43 to 51 in d51edae

	const result = await element.screenshot({
	path: screenshot.output,
	type: screenshot.type,
	omitBackground: screenshot.transparent,
	encoding: screenshot.encoding,
	quality: screenshot.quality,
	});
	screenshot.setBuffer(Buffer.from(result));

[Yazaar]

I have made some changes that could be looked into merging into the node-html-to-image library:

• Fixed issue where base64 strings are incorrectly wrapped into a Buffer object
• Added and extended test cases to verify that encoding base64 returns strings as expected
• Added and extended test cases to also verify that encoding mode 'binary' with declared output not only writes to file, but also returns a Buffer object
• Fixed a lot of typing to easier and dynamically declare if a string, Buffer, string[] or Buffer[] will be returned

I can setup a fork and pull request for review and consideration if these changes are to be accepted into the project.

See images below with some screenshots of the dynamic typing declarations.

Best regards and wishes,
Yazaar / Jesper

Return type dynamic recognition

Autosuggest of deep typing on content Array ('output' and 'selector')

===========

Prior to my changes

For reference, this is the typing prior to my changes

[Yazaar]

Hi! I have opened a pull request with my changes. While working on it I also addressed a few unrelated issues that I came across while reviewing the existing code. I have referenced some related issues that I came accross and that I found affected by these fixes.

Best regards and wishes,
Yazaar / Jesper