Skip to content

Review cases exercised by tests to ensure completeness and avoid duplication #590

@theferrit32

Description

@theferrit32

Ideally more of the variant cases would be specified in YAML or something, and then referred to by individual tests, so when we write a new unit test we can refer to those and see if we can reuse one. The variants should also be better documented as to what case they are meant to exercise. The VCF tests should also ideally overlap with those, not define different sets of variants.

We should also consider not storing the expected VCF files in git but rather checking their value programmatically against what is expected. e.g. checking the headers for the VRS headers and checking the INFO fields for what values we expect. Though one benefit to having the expected VCFs in git is that other implementers of VRS can use them to verify their own implementation. Which would be harder to do if the expected values were only in the test code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions