WIP

Signed-off-by: Koichi Shiraishi <[email protected]>

Author: zchee

cmd/protoc-gen-connect-python/generator/generator.go

@@ -7,6 +7,7 @@ package generator
 import (
 	"cmp"
 	"fmt"
+	"log"
 	"maps"
 	"path/filepath"
 	"runtime/debug"
@@ -103,6 +104,7 @@ type Method struct {
 	Method   string
 	FullName string
 	RPCType  RPCType
+	Options  protoreflect.ProtoMessage
 }
 
 type message struct {
@@ -134,12 +136,14 @@ func (g *Generator) generate(gen *protogen.GeneratedFile, f *protogen.File) {
 	}
 	for _, svc := range f.Services {
 		for i, meth := range svc.Methods {
+			log.Printf("meth.Desc.Options(): %#v\n", meth.Desc.Options())
 			fullname := string(meth.Desc.FullName())
 			idx := strings.LastIndex(fullname, ".")
 			method := Method{
 				idx:      i,
 				Method:   meth.GoName,
 				FullName: fullname[:idx],
+				Options:  meth.Desc.Options(),
 			}
 
 			// parse RPC type
@@ -174,13 +178,23 @@ func (g *Generator) generate(gen *protogen.GeneratedFile, f *protogen.File) {
 		}
 		p.P(`"""Generated connect code."""`)
 		p.P()
+		p.P(`import abc`)
 		p.P(`from enum import Enum`)
 		p.P()
-		p.P(`from connect.client import Client`)
-		p.P(`from connect.connect import StreamRequest, StreamResponse, UnaryRequest, UnaryResponse`)
-		p.P(`from connect.handler import ClientStreamHandler, Handler, ServerStreamHandler, UnaryHandler`)
-		p.P(`from connect.options import ClientOptions, ConnectOptions`)
+		p.P(`from connect import (`)
+		p.P(`    Client,`)
+		p.P(`    ClientOptions,`)
+		p.P(`    ConnectOptions,`)
+		p.P(`    Handler,`)
+		p.P(`    HandlerContext,`)
+		p.P(`    IdempotencyLevel,`)
+		p.P(`    StreamRequest,`)
+		p.P(`    StreamResponse,`)
+		p.P(`    UnaryRequest,`)
+		p.P(`    UnaryResponse,`)
+		p.P(`)`)
 		p.P(`from connect.connection_pool import AsyncConnectionPool`)
+		p.P(`from connect.handler import BidiStreamHandler, ClientStreamHandler, ServerStreamHandler, UnaryHandler`)
 		p.P(`from google.protobuf.descriptor import MethodDescriptor, ServiceDescriptor`)
 		p.P()
 
@@ -278,7 +292,7 @@ func (g *Generator) generate(gen *protogen.GeneratedFile, f *protogen.File) {
 				reqRPCType = `StreamRequest`
 				respRPCType = `StreamResponse`
 			}
-			fmt.Fprintf(&sb, "%s[%s]) -> %s[%s]: ...", reqRPCType, svc.input.method, respRPCType, svc.output.method)
+			fmt.Fprintf(&sb, "%s[%s], context: HandlerContext) -> %s[%s]:\n        raise NotImplementedError()", reqRPCType, svc.input.method, respRPCType, svc.output.method)
 			p.P(sb.String())
 			if j <= len(p.services)-2 {
 				p.P()
@@ -316,7 +330,13 @@ func (g *Generator) generate(gen *protogen.GeneratedFile, f *protogen.File) {
 				p.P(call)
 				p.P(`            input=`, svc.input.method, `,`)
 				p.P(`            output=`, svc.output.method, `,`)
-				p.P(`            options=options,`)
+				if options := meth.Options; options != nil {
+					if options.(*descriptorpb.MethodOptions).GetIdempotencyLevel() != descriptorpb.MethodOptions_IDEMPOTENCY_UNKNOWN {
+						p.P(`            options=ConnectOptions(idempotency_level=IdempotencyLevel.NO_SIDE_EFFECTS).merge(options),`)
+					} else {
+						p.P(`            options=options,`)
+					}
+				}
 				p.P(`        ),`)
 			}
 		}

examples/proto/connectrpc/eliza/v1/v1connect/eliza_connect.py

@@ -1,16 +1,26 @@
 # Generated by the protoc-gen-connect-python. DO NOT EDIT!
 # source: examples/proto/connectrpc/eliza/v1/v1connect/eliza.proto
 # Protobuf Python Version: v5.29.3
-# protoc-gen-connect-python version: v0.0.0-20250517015031-b19a36b52499+dirty
+# protoc-gen-connect-python version: v0.0.0-20250707114411-6052f0fd898c+dirty
 """Generated connect code."""
 
+import abc
 from enum import Enum
 
-from connect.client import Client
-from connect.connect import StreamRequest, StreamResponse, UnaryRequest, UnaryResponse
-from connect.handler import ClientStreamHandler, Handler, ServerStreamHandler, UnaryHandler
-from connect.options import ClientOptions, ConnectOptions
+from connect import (
+    Client,
+    ClientOptions,
+    ConnectOptions,
+    Handler,
+    HandlerContext,
+    IdempotencyLevel,
+    StreamRequest,
+    StreamResponse,
+    UnaryRequest,
+    UnaryResponse,
+)
 from connect.connection_pool import AsyncConnectionPool
+from connect.handler import BidiStreamHandler, ClientStreamHandler, ServerStreamHandler, UnaryHandler
 from google.protobuf.descriptor import MethodDescriptor, ServiceDescriptor
 
 from .. import eliza_pb2
@@ -55,13 +65,17 @@ def __init__(self, base_url: str, pool: AsyncConnectionPool, options: ClientOpti
 class ElizaServiceHandler:
     """Handler for the elizaService service."""
 
-    async def Say(self, request: UnaryRequest[SayRequest]) -> UnaryResponse[SayResponse]: ...
+    async def Say(self, request: UnaryRequest[SayRequest], context: HandlerContext) -> UnaryResponse[SayResponse]:
+        raise NotImplementedError()
 
-    async def Converse(self, request: StreamRequest[ConverseRequest]) -> StreamResponse[ConverseResponse]: ...
+    async def Converse(self, request: StreamRequest[ConverseRequest], context: HandlerContext) -> StreamResponse[ConverseResponse]:
+        raise NotImplementedError()
 
-    async def Introduce(self, request: StreamRequest[IntroduceRequest]) -> StreamResponse[IntroduceResponse]: ...
+    async def Introduce(self, request: StreamRequest[IntroduceRequest], context: HandlerContext) -> StreamResponse[IntroduceResponse]:
+        raise NotImplementedError()
 
-    async def Reflect(self, request: StreamRequest[ReflectRequest]) -> StreamResponse[ReflectResponse]: ...
+    async def Reflect(self, request: StreamRequest[ReflectRequest], context: HandlerContext) -> StreamResponse[ReflectResponse]:
+        raise NotImplementedError()
 
 
 def create_ElizaService_handlers(service: ElizaServiceHandler, options: ConnectOptions | None = None) -> list[Handler]:
@@ -71,7 +85,7 @@ def create_ElizaService_handlers(service: ElizaServiceHandler, options: ConnectO
             unary=service.Say,
             input=SayRequest,
             output=SayResponse,
-            options=options,
+            options=ConnectOptions(idempotency_level=IdempotencyLevel.NO_SIDE_EFFECTS).merge(options),
         ),
         ServerStreamHandler(
             procedure=ElizaServiceProcedures.Converse.value,