feat(new-ui): review fixes

Author: rocketraccoon

lib/adapters/test-result/testplane/index.ts

@@ -49,6 +49,24 @@ export const getStatus = (eventName: ValueOf<Testplane['events']>, events: Testp
     return TestStatus.IDLE;
 };
 
+const extractTags = (testResult: TestplaneTest | TestplaneTestResult): TestTag[] => {
+    const list: TestTag[] = [];
+
+    let current: Test | Suite | TestplaneTestResult | null = testResult;
+
+    while (current && typeof current.getTags === 'function') {
+        const tags = current?.getTags();
+
+        if (tags && tags.length > 0) {
+            list.unshift(...tags);
+        }
+
+        current = current.parent;
+    }
+
+    return list;
+};
+
 export interface TestplaneTestResultAdapterOptions {
     attempt: number;
     status: TestStatus;
@@ -254,26 +272,8 @@ export class TestplaneTestResultAdapter implements ReporterTestResult {
         return this._duration;
     }
 
-    get tags(): TestTag[] {
-        const list: TestTag[] = [];
-
-        let current: Test | Suite | TestplaneTestResult | null = this._testResult;
-
-        while (current && typeof current.getTags === 'function') {
-            const tags = current?.getTags();
-
-            if (tags && tags.length > 0) {
-                list.unshift(...tags);
-            }
-
-            current = current.parent;
-        }
-
-        return list;
-    }
-
     get attachments(): Attachment[] {
-        const tagsList = this.tags;
+        const tagsList = extractTags(this._testResult);
 
         if (tagsList.length > 0) {
             return [

lib/static/new-ui/features/suites/components/TestTags/index.module.css

@@ -11,3 +11,19 @@
     line-height: 28px;
     font-weight: 450;
 }
+
+.test-tags__hint {
+    padding: 0;
+    margin: 0;
+    display: flex;
+    gap: 4px;
+    flex-direction: column;
+}
+
+.test-tags__hint code {
+    font-size: 12px;
+    background: var(--g-color-base-generic);
+    color: var(--g-color-private-black-400);
+    padding: 2px 2px;
+    border-radius: 4px;
+}

lib/static/new-ui/features/suites/components/TestTags/index.tsx

@@ -49,7 +49,12 @@ export const TestTags = (): ReactNode => {
                 tags.list.map((tag: TestTag) => (
                     <Tooltip
                         key={tag.title}
-                        content={tag.dynamic && 'Dynamic tag'}
+                        content={tag.dynamic && (
+                            <p className={styles['test-tags__hint']}>
+                                <span>Tag was added via <code>browser.addTag()</code> command.</span>
+                                <span>Such tags can&apos;t be used with <code>--tag</code> filtering in CLI.</span>
+                            </p>
+                        )}
                     >
                         <Label
                             size="xs"

test/unit/lib/tests-tree-builder/base.js

@@ -82,7 +82,6 @@ describe('ResultsTreeBuilder', () => {
                     builder.tree.suites.byId['s1'],
                     {
                         id: 's1',
-                        hash: '8ddf878',
                         name: 's1',
                         parentId: null,
                         root: true,
@@ -101,7 +100,6 @@ describe('ResultsTreeBuilder', () => {
                     builder.tree.suites.byId['s1 s2'],
                     {
                         id: 's1 s2',
-                        hash: 'c8304d9',
                         name: 's2',
                         parentId: 's1',
                         root: false,