Add Rasterband::set_statistics
#529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netthier
force-pushed
the
raster-set-statistics
branch
from
c01e3a7 to
9a4fc03
Compare
Contributor
Author
|
It could maybe make sense to have the method take |
Signed-off-by: netthier <[email protected]>
Signed-off-by: netthier <[email protected]>
netthier
force-pushed
the
raster-set-statistics
branch
from
9a4fc03 to
ecaf51a
Compare
ChristianBeilschmidt
requested changes
Sep 26, 2024
Contributor
ChristianBeilschmidt
left a comment
ChristianBeilschmidt
left a comment
There was a problem hiding this comment.
Looks good, maybe you can add your suggestion.
| /// # Notes | ||
| /// See also: | ||
| /// [`GDALSetRasterStatistics`](https://gdal.org/api/gdalrasterband_cpp.html#_CPPv4N14GDALRasterBand13SetStatisticsEdddd) | ||
| pub fn set_statistics(&mut self, min: f64, max: f64, mean: f64, std_dev: f64) -> Result<()> { |
Contributor
There was a problem hiding this comment.
We could use StatisticsAll so that we can avoid having for floats being submitted. It is more verbose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This PR adds safe bindings for https://docs.rs/gdal-sys/latest/gdal_sys/fn.GDALSetRasterStatistics.html (https://gdal.org/api/gdalrasterband_cpp.html#_CPPv4N14GDALRasterBand13SetStatisticsEdddd).
I also fixed up the docs for
get_statisticswhere a backtick was missing.