Remove explicit close() of opened file resource if context manager is used

Signed-off-by: sschulz92 <[email protected]>

Author: sschulz92

build.py

@@ -41,12 +41,9 @@ def install():
 def create_setup_file():
     with open("setup.tmpl", "r", encoding="utf-8") as tmpl:
         tmpl_content = tmpl.read()
-        tmpl.close()
     with open("setup.py", "w+", encoding="utf-8") as setup:
         v = get_version()
-        setup.write(tmpl_content.format(
-            v, "{\n\t\t':python_version == \"2.7\"': ['futures']\n\t}"))
-        setup.close()
+        setup.write(tmpl_content.format(v))
 
 
 def generate_package():
@@ -55,7 +52,6 @@ def generate_package():
     create_setup_file()
     with open(os.devnull, 'w', encoding="utf-8") as fnull:
         call([sys.executable, 'setup.py', 'sdist'], stdout=fnull, stderr=fnull)
-        fnull.close()
 
 
 def create_zip():

getgauge/registry.py

@@ -265,7 +265,6 @@ def capture_to_file():
             content = registry.screenshot_provider()()
             with open(screenshot_file, "wb") as file:
                 file.write(content)
-                file.close()
             return os.path.basename(screenshot_file)
         screenshot_file = registry.screenshot_provider()()
         if not os.path.isabs(screenshot_file):

getgauge/util.py

@@ -36,7 +36,6 @@ def read_file_contents(file_name):
     if os.path.isfile(file_name):
         with open(file_name, "r", encoding="utf-8") as f:
             content = f.read().replace('\r\n', '\n')
-            f.close()
         return content
     return None
 

setup.tmpl

@@ -18,5 +18,4 @@ setup(
         'Programming Language :: Python :: 3 :: Only',
     ],
     install_requires=['redBaron', 'debugpy', 'grpcio>=1.39.0', 'protobuf>=3.5.2'],
-    extras_require={1},
 )

tests/test_refactor.py

@@ -15,15 +15,17 @@ class RefactorTests(unittest.TestCase):
     def setUp(self):
         self.preservesNewlines = True
         RefactorTests.path = os.path.join(tempfile.gettempdir(), 'step_impl.py')
-        RefactorTests.file = open(RefactorTests.path, 'w')
-        RefactorTests.file.write("""@step("Vowels in English language are <vowels>.")
-def assert_default_vowels(arg0):
-    Messages.write_message("Given vowels are {0}".format(given_vowels))
-    assert given_vowels == "".join(vowels)\n""")
-        RefactorTests.file.close()
-        RefactorTests.file = open(RefactorTests.path, 'r')
-        RefactorTests.data = RefactorTests.file.read()
-        RefactorTests.file.close()
+        with open(RefactorTests.path, 'w', encoding="utf-8") as refactor_file:
+            RefactorTests.file = refactor_file
+            RefactorTests.file.write("""@step("Vowels in English language are <vowels>.")
+    def assert_default_vowels(arg0):
+        Messages.write_message("Given vowels are {0}".format(given_vowels))
+        assert given_vowels == "".join(vowels)\n""")
+
+        with open(RefactorTests.path, 'r', encoding="utf-8") as refactor_file:
+            RefactorTests.file = refactor_file
+            RefactorTests.data = RefactorTests.file.read()
+
         registry.add_step('Vowels in English language are <vowels>.', None,
                           RefactorTests.path)
 
@@ -337,10 +339,9 @@ def assert_default_vowels(arg0, arg1):
         self.assertIn('arg0, arg1', diff_contents)
 
     def getActualText(self):
-        _file = open(RefactorTests.path, 'r+')
-        actual_data = _file.read()
-        _file.seek(0)
-        _file.truncate()
-        _file.write(RefactorTests.data)
-        _file.close()
+        with open(RefactorTests.path, 'r+', encoding="utf-8") as _file:
+            actual_data = _file.read()
+            _file.seek(0)
+            _file.truncate()
+            _file.write(RefactorTests.data)
         return actual_data