Skip to content

Commit 1561208

Browse files
committed
fix
1 parent 392e0a0 commit 1561208

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

src/launchpad/size/analyzers/apple.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,6 @@ def _analyze_binary(
437437
linked_libraries = parser.extract_linked_libraries()
438438
swift_protocol_conformances: List[str] = [] # parser.parse_swift_protocol_conformances()
439439
objc_method_names = parser.parse_objc_method_names()
440-
static_inits = parser.static_inits()
441440
segments = self._extract_segments_info(parser.binary)
442441
load_commands = self._extract_load_commands_info(parser.binary)
443442
dyld_info = parser.extract_dyld_info()
@@ -499,7 +498,6 @@ def _analyze_binary(
499498
header_size=parser.get_header_size(),
500499
dyld_info=dyld_info,
501500
dwarf_relocations=dwarf_relocations,
502-
static_inits=static_inits,
503501
strippable_symbols_size=strippable_symbols_size,
504502
)
505503

src/launchpad/size/models/apple.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
from pathlib import Path
77
from typing import List
88

9-
import lief
10-
119
from pydantic import BaseModel, ConfigDict, Field
1210

1311
from launchpad.parsers.apple.dwarf_relocations_parser import DwarfRelocationsData
@@ -146,17 +144,13 @@ class MachOBinaryAnalysis:
146144
architectures: List[str]
147145
linked_libraries: List[str]
148146
objc_method_names: List[str]
149-
# Lief types cannot be used after the binary is closed
150-
# so we need to extract the segment/section data into dataclasses
151147
segments: List[SegmentInfo]
152148
load_commands: List[LoadCommandInfo]
153149
swift_metadata: SwiftMetadata | None = None
154-
# TODO(EME-432): remove lief types from this model so it's safe to use after the binary is closed
155150
symbol_info: SymbolInfo | None = None
156151
header_size: int = 0
157152
dyld_info: DyldInfo | None = None
158153
dwarf_relocations: DwarfRelocationsData | None = None
159-
static_inits: List[lief.Symbol | str] | None = None
160154
strippable_symbols_size: int = 0
161155

162156

0 commit comments

Comments
 (0)