fix

Author: trevor-e

src/launchpad/size/insights/apple/main_binary_export_metadata.py

@@ -17,11 +17,11 @@ def generate(self, input: InsightsInput) -> MainBinaryExportMetadataResult | Non
             if not analysis.is_main_binary:
                 continue
 
-            dyld_info = analysis.dyld_info
-            if dyld_info is None:
+            linkedit_info = analysis.linkedit_info
+            if linkedit_info is None:
                 continue
 
-            export_trie_size = dyld_info.export_trie_size
+            export_trie_size = linkedit_info.export_trie_size
             if export_trie_size >= self.MIN_EXPORTS_THRESHOLD:
                 export_files.append(
                     FileSavingsResult(

tests/integration/size/test_treemap_generation.py

@@ -361,9 +361,27 @@ def find_node_by_path(root: TreemapElement, path: str) -> TreemapElement | None:
         # Verify __LINKEDIT segment
         has_linkedit = "__LINKEDIT" in main_exe_sections
         assert has_linkedit
-        linkedit_size = main_exe_sections["__LINKEDIT"].size
+        linkedit = main_exe_sections["__LINKEDIT"]
+        linkedit_size = linkedit.size
         assert linkedit_size == 269360
 
+        # Verify __LINKEDIT has children (symbol table, string table, etc.)
+        linkedit_children = {child.name: child for child in linkedit.children}
+        assert len(linkedit_children) == 6, "__LINKEDIT should have exactly 6 child components"
+
+        # Verify expected __LINKEDIT components exist
+        assert "Symbol Table" in linkedit_children, "Symbol table should be present"
+        assert "String Table" in linkedit_children, "String table should be present"
+        assert "Function Starts" in linkedit_children, "Function starts should be present"
+
+        # Verify exact sizes for __LINKEDIT components
+        assert linkedit_children["Symbol Table"].size == 11072, "Symbol table size mismatch"
+        assert linkedit_children["String Table"].size == 16584, "String table size mismatch"
+        assert linkedit_children["Function Starts"].size == 13584, "Function starts size mismatch"
+        assert linkedit_children["Chained Fixups"].size == 87616, "Chained fixups size mismatch"
+        assert linkedit_children["Export Trie"].size == 85056, "Export trie size mismatch"
+        assert linkedit_children["Code Signature"].size == 43488, "Code signature size mismatch"
+
         # Verify Unmapped section (track size changes)
         has_unmapped = "Unmapped" in main_exe_sections
         assert has_unmapped

tests/unit/test_main_binary_export_metadata_insight.py

@@ -2,7 +2,7 @@
 
 from launchpad.size.insights.apple.main_binary_export_metadata import MainBinaryExportMetadataInsight
 from launchpad.size.insights.insight import InsightsInput
-from launchpad.size.models.apple import DyldInfo, MachOBinaryAnalysis
+from launchpad.size.models.apple import LinkEditInfo, MachOBinaryAnalysis
 from launchpad.size.models.common import BaseAppInfo, FileAnalysis
 from launchpad.size.models.insights import MainBinaryExportMetadataResult
 
@@ -26,7 +26,7 @@ def test_generate_with_main_binary_and_dyld_exports_trie(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=5000),
+            linkedit_info=LinkEditInfo(export_trie_size=5000),
         )
 
         insights_input = InsightsInput(
@@ -42,7 +42,7 @@ def test_generate_with_main_binary_and_dyld_exports_trie(self):
         assert result.total_savings == 5000
 
     def test_generate_with_main_binary_without_dyld_exports_trie(self):
-        """Test that no insight is generated when main binary has no dyld_info."""
+        """Test that no insight is generated when main binary has no linkedit_info."""
         main_binary_analysis = MachOBinaryAnalysis(
             binary_absolute_path=Path("MyApp"),
             binary_relative_path=Path("MyApp"),
@@ -56,7 +56,7 @@ def test_generate_with_main_binary_without_dyld_exports_trie(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=None,  # No dyld_info
+            linkedit_info=None,  # No linkedit_info
         )
 
         insights_input = InsightsInput(
@@ -85,7 +85,7 @@ def test_generate_with_no_main_binary(self):
             swift_metadata=None,
             is_main_binary=False,  # Not a main binary
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=5000),  # Has export trie but not main binary
+            linkedit_info=LinkEditInfo(export_trie_size=5000),  # Has export trie but not main binary
         )
 
         insights_input = InsightsInput(
@@ -114,7 +114,7 @@ def test_generate_with_main_binary_but_empty_export_trie(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=0),  # Zero-size export trie
+            linkedit_info=LinkEditInfo(export_trie_size=0),  # Zero-size export trie
         )
 
         insights_input = InsightsInput(
@@ -156,7 +156,7 @@ def test_generate_with_multiple_binaries_one_main(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=8000),
+            linkedit_info=LinkEditInfo(export_trie_size=8000),
         )
 
         # Create framework binary (non-main)
@@ -173,7 +173,7 @@ def test_generate_with_multiple_binaries_one_main(self):
             swift_metadata=None,
             is_main_binary=False,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=3000),  # Framework also has export trie but won't be included
+            linkedit_info=LinkEditInfo(export_trie_size=3000),  # Framework also has export trie but won't be included
         )
 
         insights_input = InsightsInput(
@@ -203,7 +203,7 @@ def test_generate_with_export_trie_below_threshold(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=512),  # Below MIN_EXPORTS_THRESHOLD (1024)
+            linkedit_info=LinkEditInfo(export_trie_size=512),  # Below MIN_EXPORTS_THRESHOLD (1024)
         )
 
         insights_input = InsightsInput(
@@ -232,7 +232,7 @@ def test_generate_with_export_trie_at_threshold(self):
             swift_metadata=None,
             is_main_binary=True,
             header_size=32,
-            dyld_info=DyldInfo(export_trie_size=1024),  # Exactly at MIN_EXPORTS_THRESHOLD
+            linkedit_info=LinkEditInfo(export_trie_size=1024),  # Exactly at MIN_EXPORTS_THRESHOLD
         )
 
         insights_input = InsightsInput(