chore: Update our code to match Apple's thread name length limit (#6501)

itaybre · web-flow · commit 41b3ac378f41 · 2025-10-23T14:11:35.000-03:00
diff --git a/Sources/Sentry/SentryThreadMetadataCache.cpp b/Sources/Sentry/SentryThreadMetadataCache.cpp
@@ -17,7 +17,10 @@ isSentryOwnedThreadName(const std::string &name)
     return name.rfind("io.sentry", 0) == 0;
 }
 
-constexpr std::size_t kMaxThreadNameLength = 100;
+// Apple's `libpthread` has a hard limit of 64 characters for thread names.
+// See
+// https://github.com/apple-oss-distributions/libpthread/blob/42d026df5b07825070f60134b980a1ec2552dfee/src/pthread.c#L1178
+constexpr std::size_t kMaxThreadNameLength = 64;
 
 } // namespace
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,10 @@ isSentryOwnedThreadName(const std::string &name)`
`17`	`17`	`return name.rfind("io.sentry", 0) == 0;`
`18`	`18`	`}`
`19`	`19`
`20`		`-constexpr std::size_t kMaxThreadNameLength = 100;`
	`20`	+// Apple's `libpthread` has a hard limit of 64 characters for thread names.
	`21`	`+// See`
	`22`	`+// https://github.com/apple-oss-distributions/libpthread/blob/42d026df5b07825070f60134b980a1ec2552dfee/src/pthread.c#L1178`
	`23`	`+constexpr std::size_t kMaxThreadNameLength = 64;`
`21`	`24`
`22`	`25`	`} // namespace`
`23`	`26`