Merge pull request #139 from getsentry/feature/swiftlint-danger

Feature/swiftlint danger

Author: HazAT

.swiftlint.yml

@@ -5,6 +5,7 @@ excluded:
   - Carthage
   - Pods
   - Utils
+  - vendor
 whitelist_rules:
   #- attributes
   - class_delegate_protocol
@@ -76,7 +77,7 @@ whitelist_rules:
   - unused_optional_binding
   - valid_docs
   - valid_ibinspectable
-  - variable_name
+  #- identifier_name
   - vertical_parameter_alignment
   - vertical_whitespace
   - void_return

.travis.yml

@@ -5,14 +5,13 @@ cache:
 rvm:
     - 2.2
 before_install:
-    - gem install fastlane
-    - gem install slather
+    - bundle install
     - brew update
     - brew outdated swiftlint || brew upgrade swiftlint
-script: 
-    - travis_retry fastlane $LANE
+script:
+    - if [ "$LANE" = "lint" ]; then fastlane $LANE; else travis_retry fastlane $LANE; fi
 after_success:
-    - if [ "$LANE" = "test_swift_3_ios" ]; then bash <(curl -s https://codecov.io/bash) -f cobertura.xml; fi 
+    - if [ "$LANE" = "test_swift_3_ios" ]; then bash <(curl -s https://codecov.io/bash) -f cobertura.xml; fi
 env:
     matrix:
         - LANE=lint
@@ -21,4 +20,4 @@ env:
         - LANE=test_swift_2_macos
         - LANE=test_swift_3_tvos
         - LANE=test_swift_3_macos
-        - LANE=test_swift_3_ios
+        - LANE=test_swift_3_ios

Dangerfile

@@ -0,0 +1,8 @@
+message("Hello, I'm working :)")
+
+declared_trivial = github.pr_title.include? "#trivial"
+
+warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
+warn("Big PR") if git.lines_of_code > 500
+
+swiftlint.lint_files inline_mode: true

Gemfile

@@ -2,4 +2,6 @@ source "https://rubygems.org"
 
 gem "cocoapods"
 gem "fastlane"
-gem "slather"
+gem "slather"
+gem "danger"
+gem "danger-swiftlint"

Gemfile.lock

@@ -12,6 +12,10 @@ GEM
       public_suffix (~> 2.0, >= 2.0.2)
     babosa (1.0.2)
     claide (1.0.1)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
     clamp (0.6.5)
     cocoapods (1.1.1)
       activesupport (>= 4.0.2, < 5)
@@ -46,8 +50,26 @@ GEM
       netrc (= 0.7.8)
     cocoapods-try (1.1.0)
     colored (1.2)
+    colored2 (3.1.2)
     commander (4.4.2)
       highline (~> 1.7.2)
+    cork (0.2.0)
+      colored (~> 1.2)
+    danger (4.3.1)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (~> 0.9)
+      faraday-http-cache (~> 1.0)
+      git (~> 1)
+      kramdown (~> 1.5)
+      octokit (~> 4.2)
+      terminal-table (~> 1)
+    danger-swiftlint (0.4.0)
+      danger
+      rake (~> 10.0)
+      thor (~> 0.19)
     domain_name (0.5.20161129)
       unf (>= 0.0.5, < 1.0.0)
     dotenv (2.1.1)
@@ -58,6 +80,8 @@ GEM
     faraday-cookie_jar (0.0.6)
       faraday (>= 0.7.4)
       http-cookie (~> 1.0.0)
+    faraday-http-cache (1.3.1)
+      faraday (~> 0.8)
     faraday_middleware (0.10.1)
       faraday (>= 0.7.4, < 1.0)
     fastimage (2.0.1)
@@ -96,6 +120,7 @@ GEM
     fourflusher (2.0.1)
     fuzzy_match (2.0.4)
     gh_inspector (1.0.2)
+    git (1.3.0)
     google-api-client (0.9.20)
       addressable (~> 2.3)
       googleauth (~> 0.5)
@@ -121,6 +146,7 @@ GEM
     i18n (0.7.0)
     json (1.8.3)
     jwt (1.5.6)
+    kramdown (1.13.2)
     little-plugger (1.1.4)
     logging (2.1.0)
       little-plugger (~> 1.1)
@@ -141,14 +167,21 @@ GEM
     netrc (0.7.8)
     nokogiri (1.6.8.1)
       mini_portile2 (~> 2.1.0)
+    octokit (4.6.2)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    open4 (1.3.4)
     os (0.9.6)
     plist (3.2.0)
     public_suffix (2.0.4)
+    rake (10.5.0)
     representable (2.3.0)
       uber (~> 0.0.7)
     retriable (2.1.0)
     rouge (1.11.1)
     rubyzip (1.2.0)
+    sawyer (0.8.1)
+      addressable (>= 2.3.5, < 2.6)
+      faraday (~> 0.8, < 1.0)
     security (0.1.3)
     signet (0.7.3)
       addressable (~> 2.3)
@@ -164,6 +197,7 @@ GEM
     terminal-notifier (1.7.1)
     terminal-table (1.7.3)
       unicode-display_width (~> 1.1.1)
+    thor (0.19.4)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
@@ -189,6 +223,8 @@ PLATFORMS
 
 DEPENDENCIES
   cocoapods
+  danger
+  danger-swiftlint
   fastlane
   slather
 

Sentry.xcodeproj/project.pbxproj

@@ -1266,7 +1266,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [ \"$CI\" = \"\" ]\nthen\nif which swiftlint >/dev/null; then\nswiftlint\nelse\necho \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\nelse\necho \"warning: Skip linting\"\nfi";
+			shellScript = "if [ \"$CI\" = \"\" ] && [ \"$CARTHAGE\" = \"\" ]\nthen\nif which swiftlint >/dev/null; then\nswiftlint\nelse\necho \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\nelse\necho \"warning: Skip linting\"\nfi";
 		};
 /* End PBXShellScriptBuildPhase section */
 

fastlane/Fastfile

@@ -22,6 +22,14 @@ lane :localcoverage do
 end
 
 lane :lint do
+    if ENV["DANGER_GITHUB_API_TOKEN"]
+        danger(
+            github_api_token: ENV["DANGER_GITHUB_API_TOKEN"],
+            danger_id: "github",
+            dangerfile: "./Dangerfile",
+            verbose: true
+        )
+    end
     sh('cd .. && swiftlint')
 end