PR feedback

Author: noahsmartin

Sources/Swift/Tools/SentryScreenshot.swift

@@ -19,7 +19,7 @@ import UIKit
 
     /// Get a screenshot of every open window in the app.
     /// - Returns: An array of UIImage instances.
-    @discardableResult public func appScreenshotsFromMainThread() -> [UIImage] {
+    public func appScreenshotsFromMainThread() -> [UIImage] {
         var result: [UIImage] = []
 
         let takeScreenShot = { result = self.appScreenshots() }
@@ -84,7 +84,7 @@ import UIKit
         return result
     }
 
-    @discardableResult public func appScreenshotsData() -> [Data] {
+    public func appScreenshotsData() -> [Data] {
         let screenshots = appScreenshots()
         var result: [Data] = []
         result.reserveCapacity(screenshots.count)

Tests/SentryTests/SentryScreenShotTests.swift

@@ -41,7 +41,7 @@ class SentryScreenShotTests: XCTestCase {
         let expect = expectation(description: "Screenshot")
         let queue = DispatchQueue(label: "TestQueue")
         let _ = queue.async {
-            self.fixture.sut.appScreenshotsFromMainThread()
+            _ = self.fixture.sut.appScreenshotsFromMainThread()
             expect.fulfill()
         }
         wait(for: [expect], timeout: 1)
@@ -65,7 +65,7 @@ class SentryScreenShotTests: XCTestCase {
 
         fixture.uiApplication.windows = [firstWindow, secondWindow]
 
-        self.fixture.sut.appScreenshotsData()
+        _ = self.fixture.sut.appScreenshotsData()
 
         XCTAssertTrue(drawFirstWindow)
         XCTAssertTrue(drawSecondWindow)