From 821f8c755a8cad0dfdb73a361aceee9779485fe6 Mon Sep 17 00:00:00 2001 From: Philipp Hofmann Date: Thu, 23 Oct 2025 06:34:38 +0200 Subject: [PATCH] fix: Remove unused SentryFrame.instruction The property isn't used anywhere in the SDK, we can remove it. Fixes GH-4738 --- CHANGELOG.md | 1 + Sources/Sentry/Public/SentryFrame.h | 5 -- sdk_api.json | 83 ----------------------------- 3 files changed, 1 insertion(+), 88 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c18f438d70..e79f20825e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - Removes `enablePerformanceV2` option and makes this the default. The app start duration will now finish when the first frame is drawn instead of when the OS posts the UIWindowDidBecomeVisibleNotification. (#6008) - Removes enableTracing property from SentryOptions (#5694) - Structured Logs: Move options out of experimental (#6359) +- Remove unused `SentryFrame.instruction` property (#6504) ### Features diff --git a/Sources/Sentry/Public/SentryFrame.h b/Sources/Sentry/Public/SentryFrame.h index c459239bbd8..416336fd2c0 100644 --- a/Sources/Sentry/Public/SentryFrame.h +++ b/Sources/Sentry/Public/SentryFrame.h @@ -59,11 +59,6 @@ NS_SWIFT_NAME(Frame) */ @property (nonatomic, copy) NSString *_Nullable instructionAddress; -/** - * InstructionAddress of the frame - */ -@property (nonatomic) NSUInteger instruction; - /** * User for react native, will be ignored for cocoa frames */ diff --git a/sdk_api.json b/sdk_api.json index 186edcb5a75..e29b6be316d 100644 --- a/sdk_api.json +++ b/sdk_api.json @@ -8866,89 +8866,6 @@ } ] }, - { - "kind": "Var", - "name": "instruction", - "printedName": "instruction", - "children": [ - { - "kind": "TypeNominal", - "name": "Int", - "printedName": "Swift.Int", - "usr": "s:Si" - } - ], - "declKind": "Var", - "usr": "c:objc(cs)SentryFrame(py)instruction", - "moduleName": "Sentry", - "isOpen": true, - "objc_name": "instruction", - "declAttributes": [ - "ObjC", - "Dynamic" - ], - "accessors": [ - { - "kind": "Accessor", - "name": "Get", - "printedName": "Get()", - "children": [ - { - "kind": "TypeNominal", - "name": "Int", - "printedName": "Swift.Int", - "usr": "s:Si" - } - ], - "declKind": "Accessor", - "usr": "c:objc(cs)SentryFrame(im)instruction", - "moduleName": "Sentry", - "isOpen": true, - "objc_name": "instruction", - "declAttributes": [ - "DiscardableResult", - "ObjC", - "Dynamic" - ], - "accessorKind": "get" - }, - { - "kind": "Accessor", - "name": "Set", - "printedName": "Set()", - "children": [ - { - "kind": "TypeNameAlias", - "name": "Void", - "printedName": "Swift.Void", - "children": [ - { - "kind": "TypeNominal", - "name": "Void", - "printedName": "()" - } - ] - }, - { - "kind": "TypeNominal", - "name": "Int", - "printedName": "Swift.Int", - "usr": "s:Si" - } - ], - "declKind": "Accessor", - "usr": "c:objc(cs)SentryFrame(im)setInstruction:", - "moduleName": "Sentry", - "isOpen": true, - "objc_name": "setInstruction:", - "declAttributes": [ - "ObjC", - "Dynamic" - ], - "accessorKind": "set" - } - ] - }, { "kind": "Var", "name": "lineNumber",