From d491ded6a8d7f14b2f59e091d1a6a1c2b588ba80 Mon Sep 17 00:00:00 2001 From: Onur Temizkan Date: Tue, 5 Aug 2025 12:08:03 +0100 Subject: [PATCH] feat(remix): Set sendDefaultPii: true by default --- CHANGELOG.md | 5 +++++ e2e-tests/package.json | 2 +- e2e-tests/tests/remix.test.ts | 3 ++- src/remix/sdk-setup.ts | 3 +++ test/remix/client-entry.test.ts | 14 ++++++++++---- 5 files changed, 21 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b49b4cc..a8495d9c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## Unreleased + +- feat(remix): Set `sendDefaultPii: true` by default ([#1053](https://github.com/getsentry/sentry-wizard/pull/1053)) + + ## 6.1.2 - ref(angular,nextjs,nuxt,remix,sveltekit): Install SDK package version `@^10` ([#1048](https://github.com/getsentry/sentry-wizard/pull/1048)) diff --git a/e2e-tests/package.json b/e2e-tests/package.json index a76553b3..d3ea21b4 100644 --- a/e2e-tests/package.json +++ b/e2e-tests/package.json @@ -8,7 +8,7 @@ "test": "vitest -c ./vitest.config.ts --run --coverage" }, "volta": { - "node": "20.18.3", + "node": "22.18.0", "yarn": "1.22.19" } } diff --git a/e2e-tests/tests/remix.test.ts b/e2e-tests/tests/remix.test.ts index 261cf68d..4083fb1b 100644 --- a/e2e-tests/tests/remix.test.ts +++ b/e2e-tests/tests/remix.test.ts @@ -174,7 +174,8 @@ function checkRemixProject( })], replaysSessionSampleRate: 0.1, - replaysOnErrorSampleRate: 1 + replaysOnErrorSampleRate: 1, + sendDefaultPii: true })`, ]); }); diff --git a/src/remix/sdk-setup.ts b/src/remix/sdk-setup.ts index 0c05a912..d9513be6 100644 --- a/src/remix/sdk-setup.ts +++ b/src/remix/sdk-setup.ts @@ -74,6 +74,7 @@ interface SdkAstOptions { replaysOnErrorSampleRate?: number; integrations?: Array; enableLogs?: boolean; + sendDefaultPii?: boolean; } function getInitCallArgs( @@ -126,6 +127,8 @@ function getInitCallArgs( initCallArgs.replaysSessionSampleRate = 0.1; initCallArgs.replaysOnErrorSampleRate = 1.0; } + + initCallArgs.sendDefaultPii = true; } return initCallArgs; diff --git a/test/remix/client-entry.test.ts b/test/remix/client-entry.test.ts index 37e4177d..c0806571 100644 --- a/test/remix/client-entry.test.ts +++ b/test/remix/client-entry.test.ts @@ -46,7 +46,8 @@ describe('initializeSentryOnEntryClient', () => { })], replaysSessionSampleRate: 0.1, - replaysOnErrorSampleRate: 1 + replaysOnErrorSampleRate: 1, + sendDefaultPii: true })" `); }); @@ -80,7 +81,8 @@ describe('initializeSentryOnEntryClient', () => { })], replaysSessionSampleRate: 0.1, - replaysOnErrorSampleRate: 1 + replaysOnErrorSampleRate: 1, + sendDefaultPii: true })" `); }); @@ -120,7 +122,9 @@ describe('initializeSentryOnEntryClient', () => { useEffect, useLocation, useMatches - })] + })], + + sendDefaultPii: true })" `); }); @@ -188,7 +192,9 @@ describe('initializeSentryOnEntryClient', () => { useEffect, useLocation, useMatches - })] + })], + + sendDefaultPii: true })" `); });