-
-
Notifications
You must be signed in to change notification settings - Fork 38
fix: stops custom tooltip from flickering when hovered, fixes #2206 #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
|
so this would be a quick shot at fixing the issue but adds a new behavior with the auto-close after 3s (which most likely should be configurable via customTooltip options). What do you think about this approach? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2207 +/- ##
=========================================
- Coverage 100.0% 100.0% -0.0%
=========================================
Files 196 196
Lines 17051 17073 +22
Branches 4639 4639
=========================================
+ Hits 17051 17062 +11
- Misses 0 11 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
|
wow this seems like an extreme usage lol... that seems like a lot of code, why not simply not show the tooltip if there's not enough space when doing the positioning of the tooltip? That would be much simpler and you wouldn't have to add listener to all types of mouse events like you just did. |
|
the issue happens for us primarily due to grids with more columns than available width. if only a part of the last column is in the visible area, the available space is limited hence the mouseover. not showing the tooltip would feel more like broken UX in said case as a non tech savy user might not get the underlying reason for the missing tooltip and yep, its quite some code, but essentially all it does is debouncing current events |
but why not use the suggestion I made to do the check in the tooltip reposition function? I think, and would much prefer, less lines of code for what seems like a little check to do before positioning it. |
|
oh ok didnt notice that on phone. will check that out tomorrow 👍 |
|
hey so I'm not sure if you'll have time to update this PR soon but I'm probably going to go with a release on Monday-Tuesday..ish since I think I'm done with everything including the new Hybrid Selection Model |
fixes #2206
This fixes the issue in such a way, that a timeout is added to debounce multiple quick enter/leave event combos. Additionally a 3s total timeout is added to remove the tooltip
2025-10-27_16h46_57.mp4
references #2206