Skip to content

Commit a9f4727

Browse files
committed
ci(git-artifacts): avoid the obsolete BITNESS
In the new world, we cannot discern CPU architectures via BITNESS at all. Let's just align with how things are done in the `git-artifacts` GitHub workflow in git-for-windows/git-for-windows-automation. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 72417a8 commit a9f4727

File tree

1 file changed

+33
-32
lines changed

1 file changed

+33
-32
lines changed

.github/workflows/git-artifacts.yml

Lines changed: 33 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@ env:
1010
GIT_CONFIG_PARAMETERS: "'checkout.workers=56'"
1111
HOME: "${{github.workspace}}\\home"
1212
USERPROFILE: "${{github.workspace}}\\home"
13-
MSYSTEM: MINGW64
14-
15-
ARCH_NAME: x86_64
16-
ARCH_BITNESS: 64
13+
ARCHITECTURE: x86_64
14+
MSYSTEM: CLANGARM64
15+
MINGW_PREFIX: /clangarm64
16+
MINGW_PACKAGE_PREFIX: mingw-w64-clang-aarch64
17+
SDK_REPO_ARCH: arm64
1718

1819
jobs:
1920
build:
@@ -30,15 +31,15 @@ jobs:
3031
git config --global user.email "$USER_EMAIL" &&
3132
echo "PACKAGER=$USER_NAME <$USER_EMAIL>" >>$GITHUB_ENV
3233

33-
- name: clone git-sdk-${{env.ARCH_BITNESS}}
34+
- name: clone git-sdk-${{env.SDK_REPO_ARCH}}
3435
shell: bash
3536
run: |
3637
# cannot use `git clone` directly, to allow for PR's refs to be fetched
37-
git init --bare -b ${REF#refs/heads/} git-sdk-${{env.ARCH_BITNESS}}.git &&
38-
git -C git-sdk-${{env.ARCH_BITNESS}}.git remote add origin https://github.com/${{github.repository}} &&
39-
git -C git-sdk-${{env.ARCH_BITNESS}}.git config remote.origin.promisor true &&
40-
git -C git-sdk-${{env.ARCH_BITNESS}}.git config remote.origin.partialCloneFilter blob:none &&
41-
git -C git-sdk-${{env.ARCH_BITNESS}}.git fetch --depth=1 origin $REF:refs/heads/${REF#refs/heads/}
38+
git init --bare -b ${REF#refs/heads/} git-sdk-${{env.SDK_REPO_ARCH}}.git &&
39+
git -C git-sdk-${{env.SDK_REPO_ARCH}}.git remote add origin https://github.com/${{github.repository}} &&
40+
git -C git-sdk-${{env.SDK_REPO_ARCH}}.git config remote.origin.promisor true &&
41+
git -C git-sdk-${{env.SDK_REPO_ARCH}}.git config remote.origin.partialCloneFilter blob:none &&
42+
git -C git-sdk-${{env.SDK_REPO_ARCH}}.git fetch --depth=1 origin $REF:refs/heads/${REF#refs/heads/}
4243
env:
4344
REF: ${{github.ref}}
4445
- name: clone build-extra
@@ -47,19 +48,19 @@ jobs:
4748
- name: create build-installers artifact
4849
shell: bash
4950
run: |
50-
sh -x ./build-extra/please.sh create-sdk-artifact --sdk=git-sdk-${{env.ARCH_BITNESS}}.git build-installers &&
51+
sh -x ./build-extra/please.sh create-sdk-artifact --sdk=git-sdk-${{env.SDK_REPO_ARCH}}.git build-installers &&
5152
5253
cygpath -aw "$PWD/build-installers/usr/bin/core_perl" >>$GITHUB_PATH &&
5354
cygpath -aw "$PWD/build-installers/usr/bin" >>$GITHUB_PATH &&
54-
cygpath -aw "$PWD/build-installers/mingw${{env.ARCH_BITNESS}}/bin" >>$GITHUB_PATH &&
55+
cygpath -aw "$PWD/build-installers/${{env.MINGW_PREFIX}}/bin" >>$GITHUB_PATH &&
5556
5657
mkdir -p build-installers/usr/src &&
5758
mv build-extra build-installers/usr/src/
5859
5960
- name: Generate bundle artifacts
6061
shell: bash
6162
run: |
62-
printf '#!/bin/sh\n\nexec /mingw${{env.ARCH_BITNESS}}/bin/git.exe "$@"\n' >/usr/bin/git &&
63+
printf '#!/bin/sh\n\nexec /${{env.MINGW_PREFIX}}/bin/git.exe "$@"\n' >/usr/bin/git &&
6364
mkdir -p bundle-artifacts &&
6465
6566
{ test -n "$REPOSITORY" || REPOSITORY='${{github.repository}}'; } &&
@@ -91,18 +92,18 @@ jobs:
9192
git remote add -f origin https://github.com/git-for-windows/git &&
9293
git fetch --tags bundle-artifacts/git.bundle $(cat bundle-artifacts/next_version) &&
9394
git reset --hard $(cat bundle-artifacts/next_version)
94-
- name: Build mingw-w64-${{env.ARCH_NAME}}-git
95+
- name: Build ${{env.MINGW_PACKAGE_PREFIX}}-git
9596
shell: bash
9697
run: |
9798
set -x
9899
99100
# Make sure that there is a `/usr/bin/git` that can be used by `makepkg-mingw`
100-
printf '#!/bin/sh\n\nexec /mingw${{env.ARCH_BITNESS}}/bin/git.exe "$@"\n' >/usr/bin/git &&
101+
printf '#!/bin/sh\n\nexec /${{env.MINGW_PREFIX}}/bin/git.exe "$@"\n' >/usr/bin/git &&
101102
102103
# Restrict `PATH` to MSYS2
103-
PATH="/mingw${{env.ARCH_BITNESS}}/bin:/usr/bin:/C/Windows/system32"
104+
PATH="/${{env.MINGW_PREFIX}}/bin:/usr/bin:/C/Windows/system32"
104105
105-
sh -x /usr/src/build-extra/please.sh build-mingw-w64-git --only-${{env.ARCH_BITNESS}}-bit --build-src-pkg -o artifacts HEAD &&
106+
sh -x /usr/src/build-extra/please.sh build-mingw-w64-git --only-$ARCHITECTURE --build-src-pkg -o artifacts HEAD &&
106107
cp bundle-artifacts/ver artifacts/ &&
107108
108109
b=$PWD/artifacts &&
@@ -111,10 +112,10 @@ jobs:
111112
cp PKGBUILD.$version PKGBUILD &&
112113
git commit -s -m "mingw-w64-git: new version ($version)" PKGBUILD &&
113114
git bundle create "$b"/MINGW-packages.bundle origin/main..main)
114-
- name: Publish mingw-w64-${{env.ARCH_NAME}}-git
115+
- name: Publish ${{env.MINGW_PACKAGE_PREFIX}}-git
115116
uses: actions/upload-artifact@v4
116117
with:
117-
name: pkg-${{env.ARCH_NAME}}
118+
name: pkg-${{env.ARCHITECTURE}}
118119
path: artifacts
119120
retention-days: 5
120121

@@ -137,11 +138,11 @@ jobs:
137138
artifact: [installer, portable, mingit]
138139
fail-fast: false
139140
steps:
140-
- name: Download pkg-${{env.ARCH_NAME}}
141+
- name: Download pkg-${{env.ARCHITECTURE}}
141142
uses: actions/download-artifact@v4
142143
with:
143-
name: pkg-${{env.ARCH_NAME}}
144-
path: pkg-${{env.ARCH_NAME}}
144+
name: pkg-${{env.ARCHITECTURE}}
145+
path: pkg-${{env.ARCHITECTURE}}
145146
- name: Download bundle-artifacts
146147
uses: actions/download-artifact@v4
147148
with:
@@ -157,32 +158,32 @@ jobs:
157158
tar xf build-installers.tgz &&
158159
cygpath -aw "$PWD/build-installers/usr/bin/core_perl" >>$GITHUB_PATH &&
159160
cygpath -aw "$PWD/build-installers/usr/bin" >>$GITHUB_PATH &&
160-
cygpath -aw "$PWD/build-installers/mingw${{env.ARCH_BITNESS}}/bin" >>$GITHUB_PATH
161-
- name: Build ${{env.ARCH_BITNESS}}-bit ${{matrix.artifact}}
161+
cygpath -aw "$PWD/build-installers/${{env.MINGW_PREFIX}}/bin" >>$GITHUB_PATH
162+
- name: Build ${{env.ARCHITECTURE}} ${{matrix.artifact}}
162163
shell: bash
163164
run: |
164165
sh -x /usr/src/build-extra/please.sh make_installers_from_mingw_w64_git \
165-
--version=$(cat pkg-${{env.ARCH_NAME}}/ver) \
166+
--version=$(cat pkg-${{env.ARCHITECTURE}}/ver) \
166167
-o artifacts \
167168
--${{matrix.artifact}} \
168-
--pkg=pkg-${{env.ARCH_NAME}}/mingw-w64-${{env.ARCH_NAME}}-git-[0-9]*.tar.xz \
169-
--pkg=pkg-${{env.ARCH_NAME}}/mingw-w64-${{env.ARCH_NAME}}-git-doc-html-[0-9]*.tar.xz
169+
--pkg=pkg-${{env.ARCHITECTURE}}/${{env.MINGW_PACKAGE_PREFIX}}-git-[0-9]*.tar.xz \
170+
--pkg=pkg-${{env.ARCHITECTURE}}/${{env.MINGW_PACKAGE_PREFIX}}-git-doc-html-[0-9]*.tar.xz
170171
- name: Copy package-versions and pdbs
171172
if: matrix.artifact == 'installer'
172173
shell: bash
173174
run: |
174175
cp /usr/src/build-extra/installer/package-versions.txt artifacts/ &&
175176
176177
a=$PWD/artifacts &&
177-
p=$PWD/pkg-${{env.ARCH_NAME}} &&
178+
p=$PWD/pkg-${{env.ARCHITECTURE}} &&
178179
(cd /usr/src/build-extra &&
179180
mkdir -p cached-source-packages &&
180181
cp "$p"/*-pdb* cached-source-packages/ &&
181-
GIT_CONFIG_PARAMETERS="'windows.sdk${{env.ARCH_BITNESS}}.path='" ./please.sh bundle_pdbs --arch=${{env.ARCH_NAME}} --directory="$a" installer/package-versions.txt)
182-
- name: Publish ${{matrix.artifact}}-${{env.ARCH_NAME}}
182+
GIT_CONFIG_PARAMETERS="'windows.sdk${{env.SDK_REPO_ARCH}}.path='" ./please.sh bundle_pdbs --arch=${{env.ARCHITECTURE}} --directory="$a" installer/package-versions.txt)
183+
- name: Publish ${{matrix.artifact}}-${{env.ARCHITECTURE}}
183184
uses: actions/upload-artifact@v4
184185
with:
185-
name: ${{matrix.artifact}}-${{env.ARCH_NAME}}
186+
name: ${{matrix.artifact}}-${{env.ARCHITECTURE}}
186187
path: artifacts
187188
retention-days: 5
188189

@@ -198,7 +199,7 @@ jobs:
198199
exit 1
199200
}
200201
"$env:ProgramFiles\Git\usr\bin" | Out-File -Encoding ascii -Append $env:GITHUB_PATH
201-
"$env:ProgramFiles\Git\mingw${{env.ARCH_BITNESS}}\bin" | Out-File -Encoding ascii -Append $env:GITHUB_PATH
202+
"$env:ProgramFiles\Git\${{env.MINGW_PREFIX}}\bin" | Out-File -Encoding ascii -Append $env:GITHUB_PATH
202203
- name: Publish installer log
203204
if: matrix.artifact == 'installer' && (failure() || success())
204205
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)