Debug loopVariableAssignedToNonConstPointOrReferenceType

This is to cover the cases where the pointers are
constant but the data behind it can be mutated
through it.

Author: jeongsoolee09

cpp/misra/src/rules/RULE-9-5-1/LegacyForStatementsShouldBeSimple.ql

@@ -90,8 +90,8 @@ predicate loopVariableAssignedToNonConstPointerOrReferenceType(
     strippedType = targetType.stripTopLevelSpecifiers() and
     not strippedType.getBaseType().isConst() and
     (
-      targetType instanceof PointerType or
-      targetType instanceof ReferenceType
+      strippedType instanceof PointerType or
+      strippedType instanceof ReferenceType
     )
   |
     assignmentRhs.getEnclosingStmt().getParent*() = forLoop.getStmt() and
@@ -118,7 +118,7 @@ predicate loopVariableAssignedToNonConstPointerOrReferenceType(
  * This predicate adds two constraints to the target type, as compared to the original
  * portion of the predicate:
  *
- * 1. This predicate adds type constraint that the target type is a `ReferenceType`.
+ * 1. This predicate adds a type constraint that the target type is a `ReferenceType`.
  * 2. This predicate adds the constraint that the target type is not `const`.
  *
  * Also, this predicate requires that the call is the body of the given for-loop.