Merge pull request #45 from github/close-if-open

muan · web-flow · commit 844dbec6317e · 2020-01-29T12:19:02.000-05:00
Only trigger close if details was open
diff --git a/index.js b/index.js
@@ -289,6 +289,8 @@ function isMenuItem(el: Element): boolean {
 }
 
 function close(details: Element) {
+  const wasOpen = details.hasAttribute('open')
+  if (!wasOpen) return
   details.removeAttribute('open')
   const summary = details.querySelector('summary')
   if (summary) summary.focus()

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,8 @@ function isMenuItem(el: Element): boolean {`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`function close(details: Element) {`
	`292`	`+ const wasOpen = details.hasAttribute('open')`
	`293`	`+ if (!wasOpen) return`
`292`	`294`	`details.removeAttribute('open')`
`293`	`295`	`const summary = details.querySelector('summary')`
`294`	`296`	`if (summary) summary.focus()`