Skip to content

Commit 454ad47

Browse files
Added warning to documentation.
These strings leaking has been a known issue since at least 5 years (See github issue: actions/runner#475) regardless of whether or not this will ever be fixed the least that can be done is give the user a heads up that these 2 use cases will not mask the values. (Removing the 2 sections in their entirety might also be an option 🤔).
1 parent 95b6682 commit 454ad47

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

content/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ Write-Output "::add-mask::Mona The Octocat"
289289

290290
> [!WARNING]
291291
> Make sure you register the secret with 'add-mask' before outputting it in the build logs or using it in any other workflow commands.
292+
> This will still leak the string initialy as part of the echo statment.
292293

293294
### Example: Masking an environment variable
294295

@@ -324,6 +325,9 @@ jobs:
324325

325326
{% endpowershell %}
326327

328+
> [!WARNING]
329+
> This will still leak the string as part of the env.
330+
327331
### Example: Masking a generated output within a single job
328332

329333
If you do not need to pass your secret from one job to another job, you can:

0 commit comments

Comments
 (0)