-
Notifications
You must be signed in to change notification settings - Fork 64.5k
Fix typos in "Private keys" and "Use a webhook secret" sections #38523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Corrected grammatical issues: - Added missing verb "is" in "However, this is not as strong..." - Fixed subject-verb agreement in "signature... matches the secret" These changes improve clarity and maintain the professional quality of the documentation.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects minor grammatical errors in the “Private keys” and “Use a webhook secret” sections of the GitHub Apps best practices doc.
- Added the missing verb “is” to improve clarity in the environment‐variable recommendation.
- Fixed subject–verb agreement by changing “match” to “matches” for webhook secret verification.
|
Nice! Thanks for fixing these. I'll get this added to the merge queue once checks are passing. 💛 |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Corrected grammatical issues:
These changes improve clarity and maintain the professional quality of the documentation.
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: