From de2b0f34043cbec8cbd3cdbd8c426a1321ac24a9 Mon Sep 17 00:00:00 2001
From: Kevin Heis <heiskr@users.noreply.github.com>
Date: Thu, 29 May 2025 11:38:33 -0700
Subject: [PATCH] A11y: set sidebar headers to h2 (#55859)

---
 src/fixtures/tests/playwright-local-dev.spec.ts | 2 +-
 src/frame/components/page-header/Header.tsx     | 4 ++--
 src/frame/components/sidebar/SidebarNav.tsx     | 4 ++--
 src/release-notes/tests/release-notes-1.ts      | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/fixtures/tests/playwright-local-dev.spec.ts b/src/fixtures/tests/playwright-local-dev.spec.ts
index 3e6f4635daf0..5a37441fdd59 100644
--- a/src/fixtures/tests/playwright-local-dev.spec.ts
+++ b/src/fixtures/tests/playwright-local-dev.spec.ts
@@ -45,7 +45,7 @@ test('view the early-access links page', async ({ page }) => {
   await page.goto('/early-access')
   await turnOffExperimentsInPage(page)
   await expect(page).toHaveURL(/\/en\/early-access/)
-  await page.getByRole('heading', { name: 'Early Access documentation' }).click()
+  await page.getByRole('heading', { name: 'Early Access documentation', level: 1 }).click()
   const links = await page.$$eval(
     '#article-contents ul li a',
     (elements: HTMLAnchorElement[]) => elements,
diff --git a/src/frame/components/page-header/Header.tsx b/src/frame/components/page-header/Header.tsx
index b6a84f32301c..73ae0756f47d 100644
--- a/src/frame/components/page-header/Header.tsx
+++ b/src/frame/components/page-header/Header.tsx
@@ -236,7 +236,7 @@ export const Header = () => {
                   >
                     <AllProductsLink />
                     {error === '404' || !currentProduct || isSearchResultsPage ? null : (
-                      <div className="mt-3">
+                      <h2 className="mt-3">
                         <Link
                           data-testid="sidebar-product-dialog"
                           href={currentProduct.href}
@@ -244,7 +244,7 @@ export const Header = () => {
                         >
                           {currentProductName || currentProduct.name}
                         </Link>
-                      </div>
+                      </h2>
                     )}
                     {isRestPage && <ApiVersionPicker />}
                   </Dialog.Header>
diff --git a/src/frame/components/sidebar/SidebarNav.tsx b/src/frame/components/sidebar/SidebarNav.tsx
index 7ac2f196dfed..c2000f093064 100644
--- a/src/frame/components/sidebar/SidebarNav.tsx
+++ b/src/frame/components/sidebar/SidebarNav.tsx
@@ -40,7 +40,7 @@ export const SidebarNav = ({ variant = 'full' }: Props) => {
           <div className={cx('d-none px-4 pb-3 border-bottom d-xxl-block')}>
             <AllProductsLink />
             {showCurrentProductLink && (
-              <div className="mt-3" id="allproducts-menu">
+              <h2 className="mt-3" id="allproducts-menu">
                 <Link
                   data-testid="sidebar-product-xl"
                   href={`/${router.locale}${currentProduct.href}`}
@@ -50,7 +50,7 @@ export const SidebarNav = ({ variant = 'full' }: Props) => {
                 >
                   {currentProductName || currentProduct.name}
                 </Link>
-              </div>
+              </h2>
             )}
             {variant === 'full' && isRestPage && <ApiVersionPicker />}
           </div>
diff --git a/src/release-notes/tests/release-notes-1.ts b/src/release-notes/tests/release-notes-1.ts
index 87255b3b456c..768db5dc8709 100644
--- a/src/release-notes/tests/release-notes-1.ts
+++ b/src/release-notes/tests/release-notes-1.ts
@@ -36,7 +36,7 @@ describe('release notes', () => {
     const $ = await getDOM(`/en/enterprise-server@${oldestSupportedGhes}/admin/release-notes`)
     expect($('h1').first().text()).toBe(`Enterprise Server ${oldestSupportedGhes} release notes`)
     expect(
-      $('h2').first().text().trim().startsWith(`Enterprise Server ${oldestSupportedGhes}`),
+      $('main h2').first().text().trim().startsWith(`Enterprise Server ${oldestSupportedGhes}`),
     ).toBe(true)
   })