refactor: fix sonar lint feedback (svg/img, filter) (#2283)

refactor: sonar lint feedback (svg/img, filter)

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/components/__snapshots__/Sidebar.test.tsx.snap

@@ -24,14 +24,14 @@ export const LogoIcon: FC<ILogoIcon> = ({
   ...props
 }: ILogoIcon) => (
   <svg
+    aria-hidden="true"
     aria-label={`${APPLICATION.NAME} Logo`}
     className={cn(
       size === Size.SMALL && 'size-2.5',
       size === Size.MEDIUM && 'size-5',
       size === Size.LARGE && 'size-8',
     )}
     onClick={() => onClick?.()}
-    role="img"
     viewBox="0 0 500 500"
     xmlns="https://www.w3.org/2000/svg"
     xmlnsXlink="https://www.w3.org/1999/xlink"

src/renderer/components/icons/LogoIcon.tsx

@@ -2,11 +2,11 @@ import type { FC } from 'react';
 
 export const VolumeDownIcon: FC = () => (
   <svg
+    aria-hidden="true"
     aria-label="Volume Down Icon"
     className="size-2"
     fill="currentColor"
     height="24"
-    role="img"
     viewBox="0 0 24 24"
     width="24"
     xmlns="http://www.w3.org/2000/svg"

src/renderer/components/icons/VolumeDownIcon.tsx

@@ -2,11 +2,11 @@ import type { FC } from 'react';
 
 export const VolumeUpIcon: FC = () => (
   <svg
+    aria-hidden="true"
     aria-label="Volume Up Icon"
     className="size-2"
     fill="currentColor"
     height="24"
-    role="img"
     viewBox="0 0 24 24"
     width="24"
     xmlns="http://www.w3.org/2000/svg"

src/renderer/components/icons/VolumeUpIcon.tsx

@@ -268,9 +268,9 @@ export async function getLatestDiscussion(
   try {
     const response = await searchDiscussions(notification);
     return (
-      response.data?.data.search.nodes.filter(
+      response.data?.data.search.nodes.find(
         (discussion) => discussion.title === notification.subject.title,
-      )[0] ?? null
+      ) ?? null
     );
   } catch (err) {
     rendererLogError(