refactor: fix sonarlint issues (#2280)

setchy · web-flow · commit 538b7e5fc881 · 2025-10-08T09:24:59.000-07:00
* fix: sonarlint issues

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;

* fix: sonarlint issues

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;

* fix: sonarlint issues

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;

---------

Signed-off-by: Adam Setch &lt;adam.setch@outlook.com&gt;
diff --git a/src/main/utils.ts b/src/main/utils.ts
@@ -14,7 +14,7 @@ import { sendRendererEvent } from './events';
 
 export function takeScreenshot(mb: Menubar) {
   const date = new Date();
-  const dateStr = date.toISOString().replace(/:/g, '-');
+  const dateStr = date.toISOString().replaceAll(':', '-');
 
   const capturedPicFilePath = path.join(
     os.homedir(),
diff --git a/src/renderer/components/filters/TokenSearchInput.tsx b/src/renderer/components/filters/TokenSearchInput.tsx
@@ -19,7 +19,7 @@ interface TokenSearchInputProps {
   onRemove: (token: SearchToken) => void;
 }
 
-const INPUT_KEY_EVENTS = ['Enter', 'Tab', ' ', ','];
+const INPUT_KEY_EVENTS: Set<string> = new Set(['Enter', 'Tab', ' ', ',']);
 
 export const TokenSearchInput: FC<TokenSearchInputProps> = ({
   label,
@@ -51,7 +51,7 @@ export const TokenSearchInput: FC<TokenSearchInputProps> = ({
   }
 
   function onKeyDown(e: React.KeyboardEvent<HTMLInputElement>) {
-    if (INPUT_KEY_EVENTS.includes(e.key)) {
+    if (INPUT_KEY_EVENTS.has(e.key)) {
       tryAddToken(e);
       setShowSuggestions(false);
     } else if (e.key === 'ArrowDown') {
diff --git a/src/renderer/components/metrics/MetricPill.tsx b/src/renderer/components/metrics/MetricPill.tsx
@@ -6,14 +6,15 @@ import { Label, Stack, Text } from '@primer/react';
 import { type IconColor, Size } from '../../types';
 
 export interface IMetricPill {
-  key?: string;
   title: string;
   metric?: number;
   icon: Icon;
   color: IconColor;
 }
 
 export const MetricPill: FC<IMetricPill> = (props: IMetricPill) => {
+  const Icon = props.icon;
+
   return (
     <Label
       className="hover:bg-gitify-notification-pill-hover"
@@ -22,7 +23,7 @@ export const MetricPill: FC<IMetricPill> = (props: IMetricPill) => {
       variant="secondary"
     >
       <Stack align="center" direction="horizontal" gap="none">
-        <props.icon className={props.color} size={Size.XSMALL} />
+        <Icon className={props.color} size={Size.XSMALL} />
         {props.metric ? (
           <Text className="text-xxs px-1">{props.metric}</Text>
         ) : null}
diff --git a/src/renderer/components/primitives/Title.tsx b/src/renderer/components/primitives/Title.tsx
@@ -13,7 +13,7 @@ interface ITitle {
 }
 
 export const Title: FC<ITitle> = ({ size = 2, ...props }) => {
-  const name = props.children.toLowerCase().replace(' ', '-');
+  const name = props.children.toLowerCase().replaceAll(' ', '-');
 
   return (
     <legend>
diff --git a/src/renderer/components/settings/AppearanceSettings.tsx b/src/renderer/components/settings/AppearanceSettings.tsx
@@ -59,7 +59,6 @@ export const AppearanceSettings: FC = () => {
           <FieldLabel label="Theme:" name="theme" />
           <Select
             data-testid="settings-theme"
-            id="theme"
             onChange={(evt) =>
               updateSetting('theme', evt.target.value as Theme)
             }
diff --git a/src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap b/src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap b/src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap
diff --git a/src/renderer/utils/helpers.ts b/src/renderer/utils/helpers.ts
@@ -77,7 +77,7 @@ export function actionsURL(repositoryURL: string, filters: string[]): Link {
   }
 
   // Note: the GitHub Actions UI cannot handle encoded '+' characters.
-  return url.toString().replace(/%2B/g, '+') as Link;
+  return url.toString().replaceAll('%2B', '+') as Link;
 }
 
 async function getDiscussionUrl(notification: Notification): Promise<Link> {
diff --git a/src/renderer/utils/notifications/handlers/pullRequest.ts b/src/renderer/utils/notifications/handlers/pullRequest.ts
@@ -139,13 +139,13 @@ export async function getLatestReviewForReviewers(
       (review) => review.state === prReview.state,
     );
 
-    if (!reviewerFound) {
+    if (reviewerFound) {
+      reviewerFound.users.push(prReview.user.login);
+    } else {
       reviewers.push({
         state: prReview.state,
         users: [prReview.user.login],
       });
-    } else {
-      reviewerFound.users.push(prReview.user.login);
     }
   }
 
diff --git a/src/renderer/utils/notifications/handlers/utils.ts b/src/renderer/utils/notifications/handlers/utils.ts
@@ -32,7 +32,7 @@ export function formatForDisplay(text: string[]): string {
   return text
     .join(' ')
     .replace(/([a-z])([A-Z])/g, '$1 $2') // Add space between lowercase character followed by an uppercase character
-    .replace(/_/g, ' ') // Replace underscores with spaces
+    .replaceAll('_', ' ') // Replace underscores with spaces
     .replace(/\w+/g, (word) => {
       // Convert to proper case (capitalize first letter of each word)
       return word.charAt(0).toUpperCase() + word.slice(1).toLowerCase();
diff --git a/src/renderer/utils/notifications/native.ts b/src/renderer/utils/notifications/native.ts
@@ -22,12 +22,13 @@ export const triggerNativeNotifications = (
         return accountNotifications.notifications;
       }
 
-      const accountPreviousNotificationsIds =
-        accountPreviousNotifications.notifications.map((item) => item.id);
+      const accountPreviousNotificationsIds = new Set<string>(
+        accountPreviousNotifications.notifications.map((item) => item.id),
+      );
 
       const accountNewNotifications = accountNotifications.notifications.filter(
         (item) => {
-          return !accountPreviousNotificationsIds.includes(`${item.id}`);
+          return !accountPreviousNotificationsIds.has(`${item.id}`);
         },
       );
 
diff --git a/src/renderer/utils/notifications/notifications.ts b/src/renderer/utils/notifications/notifications.ts
@@ -42,7 +42,7 @@ function getNotifications(state: GitifyState) {
 export async function getAllNotifications(
   state: GitifyState,
 ): Promise<AccountNotifications[]> {
-  const responses = await Promise.all([...getNotifications(state)]);
+  const responses = await Promise.all(getNotifications(state));
 
   const notifications: AccountNotifications[] = await Promise.all(
     responses
diff --git a/src/renderer/utils/notifications/remove.ts b/src/renderer/utils/notifications/remove.ts
@@ -16,8 +16,8 @@ export function removeNotifications(
   }
 
   const removeNotificationAccount = notificationsToRemove[0].account;
-  const removeNotificationIDs = notificationsToRemove.map(
-    (notification) => notification.id,
+  const removeNotificationIDs = new Set<string>(
+    notificationsToRemove.map((notification) => notification.id),
   );
 
   const accountIndex = allNotifications.findIndex(
@@ -31,7 +31,7 @@ export function removeNotifications(
     updatedNotifications[accountIndex] = {
       ...updatedNotifications[accountIndex],
       notifications: updatedNotifications[accountIndex].notifications.filter(
-        (notification) => !removeNotificationIDs.includes(notification.id),
+        (notification) => !removeNotificationIDs.has(notification.id),
       ),
     };
     return updatedNotifications;
diff --git a/src/renderer/utils/zoom.ts b/src/renderer/utils/zoom.ts
@@ -7,7 +7,7 @@ const MULTIPLIER = 2;
  * @returns zoomLevel -2 to 0.5
  */
 export const zoomPercentageToLevel = (percentage: number): number => {
-  if (typeof percentage === 'undefined') {
+  if (percentage === undefined) {
     return 0;
   }
 
@@ -20,7 +20,7 @@ export const zoomPercentageToLevel = (percentage: number): number => {
  * @returns percentage 0-150
  */
 export const zoomLevelToPercentage = (zoom: number): number => {
-  if (typeof zoom === 'undefined') {
+  if (zoom === undefined) {
     return 100;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ interface TokenSearchInputProps {`
`19`	`19`	`onRemove: (token: SearchToken) => void;`
`20`	`20`	`}`
`21`	`21`
`22`		`-const INPUT_KEY_EVENTS = ['Enter', 'Tab', ' ', ','];`
	`22`	`+const INPUT_KEY_EVENTS: Set<string> = new Set(['Enter', 'Tab', ' ', ',']);`
`23`	`23`
`24`	`24`	`export const TokenSearchInput: FC<TokenSearchInputProps> = ({`
`25`	`25`	`label,`
`@@ -51,7 +51,7 @@ export const TokenSearchInput: FC<TokenSearchInputProps> = ({`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`function onKeyDown(e: React.KeyboardEvent<HTMLInputElement>) {`
`54`		`- if (INPUT_KEY_EVENTS.includes(e.key)) {`
	`54`	`+ if (INPUT_KEY_EVENTS.has(e.key)) {`
`55`	`55`	`tryAddToken(e);`
`56`	`56`	`setShowSuggestions(false);`
`57`	`57`	`} else if (e.key === 'ArrowDown') {`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ interface ITitle {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`export const Title: FC<ITitle> = ({ size = 2, ...props }) => {`
`16`		`- const name = props.children.toLowerCase().replace(' ', '-');`
	`16`	`+ const name = props.children.toLowerCase().replaceAll(' ', '-');`
`17`	`17`
`18`	`18`	`return (`
`19`	`19`	`<legend>`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,6 @@ export const AppearanceSettings: FC = () => {`
`59`	`59`	`<FieldLabel label="Theme:" name="theme" />`
`60`	`60`	`<Select`
`61`	`61`	`data-testid="settings-theme"`
`62`		`- id="theme"`
`63`	`62`	`onChange={(evt) =>`
`64`	`63`	`updateSetting('theme', evt.target.value as Theme)`
`65`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ export function actionsURL(repositoryURL: string, filters: string[]): Link {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`// Note: the GitHub Actions UI cannot handle encoded '+' characters.`
`80`		`- return url.toString().replace(/%2B/g, '+') as Link;`
	`80`	`+ return url.toString().replaceAll('%2B', '+') as Link;`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`async function getDiscussionUrl(notification: Notification): Promise<Link> {`