fix: account token encryption/decryption

Signed-off-by: Adam Setch <[email protected]>

Author: setchy

src/renderer/context/App.tsx

@@ -150,28 +150,34 @@ export const AppProvider = ({ children }: { children: ReactNode }) => {
     return Promise.all(auth.accounts.map(refreshAccount));
   }, [auth.accounts]);
 
+  // TODO - Remove migration logic in future release
   const migrateAuthTokens = useCallback(async () => {
-    let tokensMigrated = false;
-
-    for (const account of auth.accounts) {
-      /**
-       * Check if the account is using an encrypted token.
-       * If not encrypt it and save it.
-       */
-      try {
-        await decryptValue(account.token);
-      } catch (_err) {
-        const encryptedToken = await encryptValue(account.token);
-        account.token = encryptedToken as Token;
-
-        tokensMigrated = true;
-      }
-    }
+    const migratedAccounts = await Promise.all(
+      auth.accounts.map(async (account) => {
+        try {
+          await decryptValue(account.token);
+          return account;
+        } catch {
+          const encryptedToken = (await encryptValue(account.token)) as Token;
+          return { ...account, token: encryptedToken };
+        }
+      }),
+    );
 
-    if (tokensMigrated) {
-      setAuth(auth);
-      saveState({ auth, settings });
+    const tokensMigrated = migratedAccounts.some(
+      (account, index) => account.token !== auth.accounts[index]?.token,
+    );
+
+    if (!tokensMigrated) {
+      return;
     }
+
+    const updatedAuth: AuthState = {
+      accounts: migratedAccounts,
+    };
+
+    setAuth(updatedAuth);
+    saveState({ auth: updatedAuth, settings });
   }, [auth, settings]);
 
   // biome-ignore lint/correctness/useExhaustiveDependencies: Fetch new notifications when account count or filters change