Skip to content

Conversation

@Sonu0305
Copy link
Contributor

@Sonu0305 Sonu0305 commented Dec 5, 2025

No description provided.

@pr0m1th3as
Copy link
Member

fitlm also accepts tables as inputs. Perhaps you should make amendments to this PR and once everything works out, we can merge it.

@Sonu0305 Sonu0305 marked this pull request as draft December 5, 2025 06:38
@pr0m1th3as
Copy link
Member

You need to account for categorical variables in table input. This perhaps requires further changes to anovan function. Keep in mind, that MATLAB returns a linear model, so for actual compatibility, LinearModel classdef is required.

Furthermore, wilkinson notation is missing.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Dec 5, 2025

You need to account for categorical variables in table input. This perhaps requires further changes to anovan function. Keep in mind, that MATLAB returns a linear model, so for actual compatibility, LinearModel classdef is required.

Furthermore, wilkinson notation is missing.

Okay, so am I doing it in a wrong sequence, which file should I go on with first?

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Dec 5, 2025

Shall I close this pr for now then?

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Dec 5, 2025

Currently, with all the existing commits on this pr, all the tests pass.

@pr0m1th3as
Copy link
Member

I think, we need a LinearModel classdef to begin with. Leave this PR open, I will merge it if I find the time to work on it myself.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Dec 5, 2025

I think, we need a LinearModel classdef to begin with. Leave this PR open, I will merge it if I find the time to work on it myself.

Yes, so i'll leave this pr open.
In future whenever required things are in place, we can continue working on this at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants