Merge pull request #31 from nhillen/master

An update to get this working in 4.3

Author: willnationsdev

addons/godot-plugin-refresher/plugin.cfg

@@ -1,7 +1,7 @@
 [plugin]
 
 name="Godot Plugin Refresher"
-description="A toolbar addition to facilitate toggling off/on a selected plugin."
+description="A toolbar addition to facilitate toggling off/on a selected plugin. Updated for Godot 4.3"
 author="willnationsdev"
-version="1.0"
+version="1.2"
 script="plugin_refresher_plugin.gd"

addons/godot-plugin-refresher/plugin_refresher.gd

@@ -1,15 +1,15 @@
-tool
+@tool
 extends HBoxContainer
 
 signal request_refresh_plugin(p_name)
 signal confirm_refresh_plugin(p_name)
 
-onready var options = $OptionButton
+@onready var options = $OptionButton
 
 func _ready():
 	if get_tree().edited_scene_root == self:
 		return # This is the scene opened in the editor!
-	$RefreshButton.icon = get_icon("Reload", "EditorIcons")
+	$RefreshButton.icon = EditorInterface.get_editor_theme().get_icon("Reload", "EditorIcons")
 
 
 func update_items(p_plugins):
@@ -27,7 +27,7 @@ func update_items(p_plugins):
 func select_plugin(p_name):
 	if not options:
 		return
-	if p_name == null or p_name.empty():
+	if p_name == null or p_name.is_empty():
 		return
 
 	for idx in options.get_item_count():
@@ -42,7 +42,7 @@ func _on_RefreshButton_pressed():
 		return # nothing selected
 
 	var plugin = options.get_item_metadata(options.selected)
-	if not plugin or plugin.empty():
+	if not plugin or plugin.is_empty():
 		return
 	emit_signal("request_refresh_plugin", plugin)
 

addons/godot-plugin-refresher/plugin_refresher.tscn

@@ -1,35 +1,20 @@
-[gd_scene load_steps=2 format=2]
+[gd_scene load_steps=2 format=3 uid="uid://dnladpgp5dwts"]
 
-[ext_resource path="res://addons/godot-plugin-refresher/plugin_refresher.gd" type="Script" id=1]
+[ext_resource type="Script" path="res://addons/godot-plugin-refresher/plugin_refresher.gd" id="1"]
 
 [node name="HBoxContainer" type="HBoxContainer"]
-margin_right = 40.0
-margin_bottom = 40.0
-script = ExtResource( 1 )
-__meta__ = {
-"_edit_use_anchors_": false
-}
+script = ExtResource("1")
 
 [node name="VSeparator" type="VSeparator" parent="."]
-margin_right = 4.0
-margin_bottom = 40.0
+layout_mode = 2
 
 [node name="OptionButton" type="OptionButton" parent="."]
-margin_left = 8.0
-margin_right = 158.0
-margin_bottom = 40.0
-rect_min_size = Vector2( 150, 0 )
+layout_mode = 2
 
-[node name="RefreshButton" type="ToolButton" parent="."]
-margin_left = 162.0
-margin_right = 174.0
-margin_bottom = 40.0
+[node name="RefreshButton" type="Button" parent="."]
+layout_mode = 2
 
 [node name="ConfirmationDialog" type="ConfirmationDialog" parent="."]
-margin_right = 278.0
-margin_bottom = 110.0
-rect_min_size = Vector2( 300, 70 )
-window_title = "Plugin Refresher"
 dialog_autowrap = true
 
 [connection signal="pressed" from="RefreshButton" to="." method="_on_RefreshButton_pressed"]

addons/godot-plugin-refresher/plugin_refresher_plugin.gd

@@ -1,4 +1,4 @@
-tool
+@tool
 extends EditorPlugin
 
 const ADDONS_PATH = "res://addons/"
@@ -11,15 +11,15 @@ var plugin_config = ConfigFile.new()
 var refresher
 
 func _enter_tree():
-	refresher = preload("plugin_refresher.tscn").instance()
+	refresher = preload("plugin_refresher.tscn").instantiate()
 	add_control_to_container(CONTAINER_TOOLBAR, refresher)
 
 	# Watch whether any plugin is changed, added or removed on the filesystem
 	var efs = get_editor_interface().get_resource_filesystem()
-	efs.connect("filesystem_changed", self, "_on_filesystem_changed")
+	efs.filesystem_changed.connect(_on_filesystem_changed)
 
-	refresher.connect("request_refresh_plugin", self, "_on_request_refresh_plugin")
-	refresher.connect("confirm_refresh_plugin", self, "_on_confirm_refresh_plugin")
+	refresher.request_refresh_plugin.connect(_on_request_refresh_plugin)
+	refresher.confirm_refresh_plugin.connect(_on_confirm_refresh_plugin)
 
 	_reload_plugins_list()
 	_load_settings()
@@ -35,63 +35,63 @@ func _reload_plugins_list():
 	var plugins = {}
 	var origins = {}
 
-	var dir = Directory.new()
-	dir.open(ADDONS_PATH)
-	dir.list_dir_begin(true, true)
-	var file = dir.get_next()
-	while file:
-		var addon_dir = ADDONS_PATH.plus_file(file)
-		if dir.dir_exists(addon_dir) and file != refresher_dir:
-			var display_name = file
-			var plugin_config_path = addon_dir.plus_file("plugin.cfg")
-			if not dir.file_exists(plugin_config_path):
-				file = dir.get_next()
-				continue # not a plugin
-			var plugin_cfg = ConfigFile.new()
-			plugin_cfg.load(plugin_config_path)
-			display_name = plugin_cfg.get_value("plugin", "name", file)
-			if not display_name in origins:
-				origins[display_name] = [file]
-			else:
-				origins[display_name].append(file)
-			plugins[file] = display_name
-		file = dir.get_next()
-
-	# Specify the exact plugin name in parenthesis in case of naming collisions.
-	for display_name in origins:
-		var plugin_names = origins[display_name]
-		if plugin_names.size() > 1:
-			for n in plugin_names:
-				plugins[n] = "%s (%s)" % [display_name, n]
-
-	refresher.update_items(plugins)
-
+	var dir = DirAccess.open(ADDONS_PATH)
+	if dir:
+		dir.list_dir_begin()
+		var file_name = dir.get_next()
+		while file_name != "":
+			
+			var addon_dir = ADDONS_PATH.path_join(file_name)
+			if dir.dir_exists(addon_dir) and file_name != refresher_dir:
+				var display_name = file_name
+				
+				var plugin_config_path = addon_dir.path_join("plugin.cfg")
+				if not dir.file_exists(plugin_config_path):
+					file_name = dir.get_next()
+					continue # not a plugin
+				var plugin_cfg = ConfigFile.new()
+				plugin_cfg.load(plugin_config_path)
+				display_name = plugin_cfg.get_value("plugin", "name", file_name)
+				if not display_name in origins:
+					origins[display_name] = [file_name]
+				else:
+					origins[display_name].append(file_name)
+				plugins[file_name] = display_name
+			file_name = dir.get_next()
+
+		# Specify the exact plugin name in parenthesis in case of naming collisions.
+		for display_name in origins:
+			var plugin_names = origins[display_name]
+			if plugin_names.size() > 1:
+				for n in plugin_names:
+					plugins[n] = "%s (%s)" % [display_name, n]
+
+		refresher.update_items(plugins)
 
 func _load_settings():
 	var path = get_config_path()
 
-	var fs = Directory.new()
-	if not fs.file_exists(path):
+	if not FileAccess.file_exists(path):
 		# Create new if running for the first time
 		var config = ConfigFile.new()
-		fs.make_dir_recursive(path.get_base_dir())
+		DirAccess.make_dir_recursive_absolute(path.get_base_dir())
 		config.save(path)
 	else:
 		plugin_config.load(path)
 
-
 func _save_settings():
 	plugin_config.save(get_config_path())
 
 
-func get_config_path():
-	var dir = get_editor_interface().get_editor_settings().get_project_settings_dir()
-	var home = dir.plus_file(PLUGIN_CONFIG_DIR)
-	var path = home.plus_file(PLUGIN_CONFIG)
+func get_config_path() -> String:
+	var editor_paths = EditorInterface.get_editor_paths()
+	var dir = editor_paths.get_project_settings_dir()
+	
+	var home = dir.path_join(PLUGIN_CONFIG_DIR)
+	var path = home.path_join(PLUGIN_CONFIG)
 
 	return path
 
-
 func _on_filesystem_changed():
 	if refresher:
 		_reload_plugins_list()
@@ -107,7 +107,7 @@ func get_recent_plugin():
 
 
 func _on_request_refresh_plugin(p_name):
-	assert(not p_name.empty())
+	assert(not p_name.is_empty())
 
 	var disabled = not get_editor_interface().is_plugin_enabled(p_name)
 	if disabled: