Skip to content

Commit 684e447

Browse files
authored
Merge pull request #1165 from adamscott/release-4.5-hotfix-3-oh-no
Two hotfixes for the website
2 parents bc034d1 + ce11dc8 commit 684e447

File tree

5 files changed

+21
-10
lines changed

5 files changed

+21
-10
lines changed

assets/js/releases/4.5.mjs

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ if (intlBlockquote == null) {
826826
// Source for the translations: https://www.berlitz.com/blog/hello-different-languages
827827
const intlBlockquoteTextEntries = [
828828
{ text: "Hello" }, // en (English)
829-
{ text: "مرحبًا", rtl: true }, // ar (Arabic)
829+
{ text: "مرحبًا", rtl: true, doNotBreakCharacters: true }, // ar (Arabic)
830830
{ text: "你好" }, // zh (Chinese)
831831
{ text: "Hallo" }, // nl (Dutch)
832832
{ text: "Bonjour" }, // fr (French)
@@ -836,7 +836,7 @@ const intlBlockquoteTextEntries = [
836836
{ text: "Ciao" }, // it (Italian)
837837
{ text: "こんにちは" }, // ja (Japanese)
838838
{ text: "안녕하세요" }, // ko (Korean)
839-
{ text: "سلام", rtl: true }, // fa (Persian)
839+
{ text: "سلام", rtl: true, doNotBreakCharacters: true }, // fa (Persian)
840840
{ text: "Cześć" }, // pl (Polish)
841841
{ text: "Olá" }, // pt (Portuguese)
842842
{ text: "Oi" }, // pt-BR (Portuguese (Brazil))
@@ -853,6 +853,8 @@ for (const intlBlockquoteTextEntry of intlBlockquoteTextEntries) {
853853
entry.classList.add("entry");
854854
entry.textContent = intlBlockquoteTextEntry.text;
855855
entry.style.direction = intlBlockquoteTextEntry?.rtl ? "rtl" : "ltr";
856+
entry.dataset.doNotBreakCharacters =
857+
intlBlockquoteTextEntry?.doNotBreakCharacters ?? false;
856858
intlBlockquote.append(entry);
857859
}
858860

@@ -864,10 +866,19 @@ const intlBlockquoteTimeline = createTimeline({
864866
});
865867

866868
for (const intlBlockquoteEntry of intlBlockquoteEntries) {
867-
const { chars } = text.split(intlBlockquoteEntry, {
868-
chars: { wrap: "clip" },
869-
});
870-
const entryAnimation = animate(chars, {
869+
let elements = null;
870+
if (intlBlockquoteEntry.dataset.doNotBreakCharacters === "true") {
871+
const { words } = text.split(intlBlockquoteEntry, {
872+
words: { wrap: "clip" },
873+
});
874+
elements = words;
875+
} else {
876+
const { chars } = text.split(intlBlockquoteEntry, {
877+
chars: { wrap: "clip" },
878+
});
879+
elements = chars;
880+
}
881+
const entryAnimation = animate(elements, {
871882
y: [
872883
{ to: ["120%", "0%"] },
873884
{ to: "-120%", delay: prefersReducedMotion ? 0 : 750, ease: "in(3)" },

collections/_article/godot-4-4-a-unified-experience.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: Godot 4.4, a unified experience
33
excerpt: Look forward to plenty of quality of life improvements hidden within this release. Faster load speeds, reduced stutter, streamlined processes — spotting all the optimizations that have been applied in the background will take some time.
44
categories: ["release"]
55
author: "Godot contributors"
6-
image: /storage/blog/covers/godot-4-4-a-unified-experience.webp
6+
image: /storage/blog/covers/godot-4-4-a-unified-experience.webp?cache=v2
77
date: 2025-03-03 15:45:00
88
redirect_to:
99
- /releases/4.4/

collections/_article/godot-4-5-making-dreams-accessible.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: Godot 4.5, making dreams accessible
33
excerpt: From mind-blowing effects now made possible by the stencil buffer to accessibilty descriptions of your GUI elements that opens up the possibility for some with disabilities to play your game — we are proud to present to you Godot 4.5.
44
categories: ["release"]
55
author: "Godot contributors"
6-
image: /storage/blog/covers/godot-4-5-making-dreams-accessible.webp
6+
image: /storage/blog/covers/godot-4-5-making-dreams-accessible.webp?cache=v2
77
date: 2025-09-15 20:00:00
88
redirect_to:
99
- /releases/4.5/

pages/releases/4.4.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
permalink: /releases/4.4/index.html
44
title: Godot 4.4, a unified experience
55
description: Look forward to plenty of quality of life improvements hidden within this release. Faster load speeds, reduced stutter, streamlined processes - spotting all the optimizations that have been applied in the background will take some time.
6-
image: /storage/blog/covers/godot-4-4-a-unified-experience.webp
6+
image: /storage/blog/covers/godot-4-4-a-unified-experience.webp?cache=v2
77
layout: release
88

99
todo_for_authors_list: >

pages/releases/4.5.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
permalink: /releases/4.5/index.html
44
title: Godot 4.5, making dreams accessible
55
description: From mind-blowing effects now made possible by the stencil buffer to accessible descriptions of your GUI elements that opens up the possibility for people with disabilities to play your game — we are proud to present to you Godot 4.5.
6-
image: /storage/blog/covers/godot-4-5-making-dreams-accessible.webp
6+
image: /storage/blog/covers/godot-4-5-making-dreams-accessible.webp?cache=v2
77
layout: release
88

99
todo_for_authors_list: >

0 commit comments

Comments
 (0)