Merge pull request #144 from gofiber/add-cbor-in-mimeExtension-list

Author: ReneWerner87

bytes.go

@@ -6,15 +6,15 @@ package utils
 
 // ToLowerBytes converts ascii slice to lower-case
 func ToLowerBytes(b []byte) []byte {
-	for i := 0; i < len(b); i++ {
+	for i := range b {
 		b[i] = toLowerTable[b[i]]
 	}
 	return b
 }
 
 // ToUpperBytes converts ascii slice to upper-case
 func ToUpperBytes(b []byte) []byte {
-	for i := 0; i < len(b); i++ {
+	for i := range b {
 		b[i] = toUpperTable[b[i]]
 	}
 	return b

common.go

@@ -13,6 +13,7 @@ import (
 	"os"
 	"reflect"
 	"runtime"
+	"slices"
 	"strconv"
 	"strings"
 	"sync"
@@ -105,12 +106,7 @@ func FunctionName(fn any) string {
 
 // GetArgument check if key is in arguments
 func GetArgument(arg string) bool {
-	for i := range os.Args[1:] {
-		if os.Args[1:][i] == arg {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(os.Args[1:], arg)
 }
 
 // IncrementIPRange Find available next IP address

http.go

@@ -168,6 +168,7 @@ var mimeExtensions = map[string]string{
 	"shtml":   "text/html",
 	"css":     "text/css",
 	"xml":     "application/xml",
+	"cbor":    "application/cbor",
 	"gif":     "image/gif",
 	"jpeg":    "image/jpeg",
 	"jpg":     "image/jpeg",

http_test.go

@@ -32,6 +32,9 @@ func Test_GetMIME(t *testing.T) {
 	res = GetMIME("zst")
 	require.Equal(t, "application/zstd", res)
 
+	res = GetMIME("cbor")
+	require.Equal(t, "application/cbor", res)
+
 	// empty case
 	res = GetMIME("")
 	require.Equal(t, "", res)

ips.go

@@ -7,6 +7,7 @@ import (
 // IsIPv4 works the same way as net.ParseIP,
 // but without check for IPv6 case and without returning net.IP slice, whereby IsIPv4 makes no allocations.
 func IsIPv4(s string) bool {
+	//nolint:modernize-loop // old way is more readable
 	for i := 0; i < net.IPv4len; i++ {
 		if len(s) == 0 {
 			return false