chore: update implementation

Author: ldez

.golangci.next.reference.yml

@@ -2492,16 +2492,33 @@ linters-settings:
         disabled: false
         exclude: [""]
         arguments:
-          - "preserveScope"
           - "checkPrivateReceivers"
-          - "sayRepetitiveInsteadOfStutters"
+          - "disableStutteringCheck"
+          - "checkPublicInterface"
+          - "disableChecksOnFunctions"
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#file-header
       - name: file-header
         severity: warning
         disabled: false
         exclude: [""]
         arguments:
           - This is the text that must appear at the top of source files.
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#file-length-limit
+      - name: file-length-limit
+        severity: warning
+        disabled: false
+        exclude: [""]
+        arguments:
+          - max: 100
+            skipComments: true
+            skipBlankLines: true
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#filename-format
+      - name: filename-format
+        severity: warning
+        disabled: false
+        exclude: [""]
+        arguments:
+          - "^[_a-z][_a-z0-9]*.go$"
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#flag-parameter
       - name: flag-parameter
         severity: warning
@@ -2629,6 +2646,8 @@ linters-settings:
         severity: warning
         disabled: false
         exclude: [""]
+        arguments:
+          - maxLength: 2
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#redefines-builtin-id
       - name: redefines-builtin-id
         severity: warning

jsonschema/golangci.next.jsonschema.json

@@ -248,6 +248,8 @@
         "errorf",
         "exported",
         "file-header",
+        "file-length-limit",
+        "filename-format",
         "flag-parameter",
         "function-length",
         "function-result-limit",

pkg/golinters/revive/revive.go

@@ -184,8 +184,8 @@ func toIssue(pass *analysis.Pass, object *jsonObject) goanalysis.Issue {
 // This function mimics the GetConfig function of revive.
 // This allows to get default values and right types.
 // https://github.com/golangci/golangci-lint/issues/1745
-// https://github.com/mgechev/revive/blob/v1.4.0/config/config.go#L218
-// https://github.com/mgechev/revive/blob/v1.4.0/config/config.go#L170-L176
+// https://github.com/mgechev/revive/blob/v1.5.0/config/config.go#L220
+// https://github.com/mgechev/revive/blob/v1.5.0/config/config.go#L172-L178
 func getConfig(cfg *config.ReviveSettings) (*lint.Config, error) {
 	conf := defaultConfig()
 
@@ -284,7 +284,7 @@ func safeTomlSlice(r []any) []any {
 }
 
 // This element is not exported by revive, so we need copy the code.
-// Extracted from https://github.com/mgechev/revive/blob/v1.4.0/config/config.go#L16
+// Extracted from https://github.com/mgechev/revive/blob/v1.5.0/config/config.go#L16
 var defaultRules = []lint.Rule{
 	&rule.VarDeclarationsRule{},
 	&rule.PackageCommentsRule{},
@@ -368,12 +368,14 @@ var allRules = append([]lint.Rule{
 	&rule.EnforceSliceStyleRule{},
 	&rule.MaxControlNestingRule{},
 	&rule.CommentsDensityRule{},
+	&rule.FileLengthLimitRule{},
+	&rule.FilenameFormatRule{},
 }, defaultRules...)
 
 const defaultConfidence = 0.8
 
 // This element is not exported by revive, so we need copy the code.
-// Extracted from https://github.com/mgechev/revive/blob/v1.4.0/config/config.go#L181
+// Extracted from https://github.com/mgechev/revive/blob/v1.5.0/config/config.go#L183
 func normalizeConfig(cfg *lint.Config) {
 	// NOTE(ldez): this custom section for golangci-lint should be kept.
 	// ---
@@ -419,7 +421,7 @@ func normalizeConfig(cfg *lint.Config) {
 }
 
 // This element is not exported by revive, so we need copy the code.
-// Extracted from https://github.com/mgechev/revive/blob/v1.4.0/config/config.go#L181
+// Extracted from https://github.com/mgechev/revive/blob/v1.5.0/config/config.go#L252
 func defaultConfig() *lint.Config {
 	defaultConfig := lint.Config{
 		Confidence: defaultConfidence,

pkg/golinters/revive/revive_integration_test.go

@@ -1,11 +1,59 @@
 package revive
 
 import (
+	"fmt"
+	"reflect"
+	"slices"
+	"strings"
 	"testing"
 
 	"github.com/golangci/golangci-lint/test/testshared/integration"
+	"github.com/mgechev/revive/lint"
 )
 
 func TestFromTestdata(t *testing.T) {
 	integration.RunTestdata(t)
 }
+
+func TestGenerate(t *testing.T) {
+	slices.SortFunc(allRules, func(a, b lint.Rule) int {
+		return strings.Compare(a.Name(), b.Name())
+	})
+
+	prefix := "      "
+
+	for _, r := range allRules {
+		fmt.Println(prefix + "# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#" + r.Name())
+		fmt.Println(prefix+"- name:", r.Name())
+		fmt.Println(prefix + "  severity: warning")
+		fmt.Println(prefix + "  disabled: false")
+		fmt.Println(prefix + "  exclude: [\"\"]")
+
+		elem := reflect.TypeOf(r).Elem()
+
+		var names []string
+		for i := 0; i < elem.NumField(); i++ {
+			if elem.Field(i).Anonymous {
+				continue
+			}
+
+			name := elem.Field(i).Name
+			if name == "configured" {
+				continue
+			}
+
+			names = append(names, name)
+		}
+
+		switch len(names) {
+		case 0:
+			// skip
+		case 1:
+			// field, _ := elem.FieldByName(names[0])
+			fmt.Println(prefix + "  arguments: [ ]")
+
+		default:
+			fmt.Println(prefix + "  arguments:")
+		}
+	}
+}