Dependencies addition of soyutils_usegoog.js makes hard to compile soy files

[itchyny]

We're facing compile errors on upgrading Closure Templates to 2023-09-13. We include soyutils_usegoog.js to our code base to compile our soy files. However, recent changes of this file adds external dependencies jspb and safevalues, and we cannot compile our soy files anymore. How can we resolve the modules?

src/js/soyutils/soyutils_usegoog.js:46:264 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "safevalues" never defined.
const {SafeHtml: TsSafeHtml, SafeScript: TsSafeScript, SafeStyle: TsSafeStyle, SafeStyleSheet: TsSafeStyleSheet, SafeUrl: TsSafeUrl, TrustedResourceUrl: TsTrustedResourceUrl, unwrapHtml, unwrapResourceUrl, unwrapScript, unwrapStyle, unwrapStyleSheet, unwrapUrl} = goog.require('safevalues');
                                                                                                                                                                                                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^

src/js/soyutils/soyutils_usegoog.js:48:35 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "jspb.immutable_message" never defined.
const {defaultImmutableInstance} = goog.require('jspb.immutable_message');
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/js/soyutils/soyutils_usegoog.js:49:27 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "safevalues.restricted.reviewed" never defined.
const {htmlSafeByReview} = goog.require('safevalues.restricted.reviewed');
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[edg84]

#1642 (comment)

[edg84]

src/js/soyutils/soyutils_usegoog.js:46:264 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "safevalues" never defined.
const {SafeHtml: TsSafeHtml, SafeScript: TsSafeScript, SafeStyle: TsSafeStyle, SafeStyleSheet: TsSafeStyleSheet, SafeUrl: TsSafeUrl, TrustedResourceUrl: TsTrustedResourceUrl, unwrapHtml, unwrapResourceUrl, unwrapScript, unwrapStyle, unwrapStyleSheet, unwrapUrl} = goog.require('safevalues');
^^^^^^^^^^^^^^^^^^^^^^^^^^

src/js/soyutils/soyutils_usegoog.js:48:35 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "jspb.immutable_message" never defined.
const {defaultImmutableInstance} = goog.require('jspb.immutable_message');
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/js/soyutils/soyutils_usegoog.js:49:27 ERROR - [JSC_MISSING_MODULE_OR_PROVIDE] Required namespace "safevalues.restricted.reviewed" never defined.
const {htmlSafeByReview} = goog.require('safevalues.restricted.reviewed');
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[emspishak]

safevalues is here: https://github.com/google/safevalues/

[itchyny]

We know where safevalues is, but we still need instruction to deal with the situation. Since safevalues is written in ES Modules, we have to include all the source code under src/ directory to our code base, and specify the files to --js option. It is painful to keep the file sync into the repository, and also make it difficult to sync the file list for --js option. We hope soyutils_usegoog.js does not depend on external library in the future. Due to this issue and also to Closure Library EOL, we freeze the closure dependencies and now migrating from them.

[edg84]

https://github.com/square/.github.git