From c1d06d4c468c7f94287d2cf5481adadb49b3cba7 Mon Sep 17 00:00:00 2001 From: Simon Taeter <35398967+STTR13@users.noreply.github.com> Date: Wed, 18 May 2022 12:38:34 +0200 Subject: [PATCH 1/2] Fix buggy docker/atari/Dockerfile There where some simple mistakes with the way the Roms.rar file was extracted mixing it up with Roms.zip. It maid the Docker file fail. --- docker/atari/Dockerfile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docker/atari/Dockerfile b/docker/atari/Dockerfile index f883fd3d..3322ac6f 100644 --- a/docker/atari/Dockerfile +++ b/docker/atari/Dockerfile @@ -10,11 +10,10 @@ FROM ${base_image} RUN mkdir /root/roms COPY ./Roms.rar /root/roms/ -RUN apt-get install rar unzip -y -RUN rar x /root/roms/Roms.rar /root/roms/ +RUN apt-get install unrar -y +RUN rar x -o+ /root/roms/Roms.rar /root/roms/ # Install ROMs with ale-py. RUN pip install atari_py ale-py -RUN unzip /root/roms/ROMS.zip -d /root/roms RUN python -m atari_py.import_roms /root/roms RUN ale-import-roms /root/roms/ROMS From be469d529f0d425fbdc0eb4d79fc0d0bb03f2c1c Mon Sep 17 00:00:00 2001 From: Simon Taeter <35398967+STTR13@users.noreply.github.com> Date: Wed, 18 May 2022 12:47:30 +0200 Subject: [PATCH 2/2] Small mistake in previous commit --- docker/atari/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/atari/Dockerfile b/docker/atari/Dockerfile index 3322ac6f..bb437e88 100644 --- a/docker/atari/Dockerfile +++ b/docker/atari/Dockerfile @@ -11,7 +11,7 @@ RUN mkdir /root/roms COPY ./Roms.rar /root/roms/ RUN apt-get install unrar -y -RUN rar x -o+ /root/roms/Roms.rar /root/roms/ +RUN unrar x -o+ /root/roms/Roms.rar /root/roms/ # Install ROMs with ale-py. RUN pip install atari_py ale-py