Skip to content

Commit 3da59dd

Browse files
committed
feedback
1 parent 653f786 commit 3da59dd

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

filament/backend/src/opengl/platforms/PlatformEGL.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,7 @@ void PlatformEGL::clearGlError() noexcept {
107107

108108
// ---------------------------------------------------------------------------------------------
109109

110-
PlatformEGL::PlatformEGL() noexcept : OpenGLPlatform() {
111-
mMSAA4XSupport = checkIfMSAASwapChainSupported(4);
112-
}
110+
PlatformEGL::PlatformEGL() noexcept = default;
113111

114112
int PlatformEGL::getOSVersion() const noexcept {
115113
return 0;
@@ -324,6 +322,7 @@ Driver* PlatformEGL::createDriver(void* sharedContext, const DriverConfig& drive
324322

325323
mCurrentContextType = ContextType::UNPROTECTED;
326324
mContextAttribs = std::move(contextAttribs);
325+
mMSAA4XSupport = checkIfMSAASwapChainSupported(4);
327326

328327
initializeGlExtensions();
329328

@@ -497,9 +496,7 @@ bool PlatformEGL::isMSAASwapChainSupported(uint32_t samples) const noexcept {
497496
return mMSAA4XSupport;
498497
}
499498

500-
// Other sample counts are not cached, retrieve it.
501-
LOG(INFO) << "MSAA sample count " << samples << " is queried, consider caching it.";
502-
return checkIfMSAASwapChainSupported(samples);
499+
return false;
503500
}
504501

505502
Platform::SwapChain* PlatformEGL::createSwapChain(

0 commit comments

Comments
 (0)